Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 471223002: Fixing VerifyLoadedModules not freeing the loaded dll. (Closed)

Created:
6 years, 4 months ago by pmonette
Modified:
6 years, 4 months ago
Reviewers:
robertshield, robert
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@binsign
Project:
chromium
Visibility:
Public.

Description

GetModuleHandleEx was incrementing the module ref count so the library was not freed at the end of the test. Another unrelated unit test was expecting the dll to not be loaded. Using GetModuleHandle now to avoid the ref count increment. BUG=401854 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290025

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment to make explicit that we do not want to change the ref count. #

Patch Set 3 : Sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pmonette_google.com
PTAL
6 years, 4 months ago (2014-08-14 21:32:30 UTC) #1
robertshield
LGTM with two changes: 1) Please reference the bug for the rest of the verification ...
6 years, 4 months ago (2014-08-15 01:16:34 UTC) #2
pmonette_google.com
The CQ bit was checked by pmonette@google.com
6 years, 4 months ago (2014-08-15 18:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmonette@google.com/471223002/40001
6 years, 4 months ago (2014-08-15 18:32:28 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:58:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290025

Powered by Google App Engine
This is Rietveld 408576698