Fixing VerifyLoadedModules not freeing the loaded dll.

chrome/browser/safe_browsing/environment_data_collection_win_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/environment_data_collection_win.h"
 
 #include <string>
 
 #include "base/base_paths.h"
 #include "base/files/file_path.h"
@@ skipping 162 matching lines @@
 TEST(SafeBrowsingEnvironmentDataCollectionWinTest, VerifyLoadedModules) {
   //  Load the test modules.
   std::vector<base::ScopedNativeLibrary> test_dlls(
       safe_browsing::kTestDllNamesCount);
   for (size_t i = 0; i < safe_browsing::kTestDllNamesCount; ++i) {
     test_dlls[i].Reset(LoadNativeLibrary(
         base::FilePath(safe_browsing::kTestDllNames[i]), NULL));
   }
 
   // Edit the first byte of the function exported by the first module.
-  HMODULE module_handle = NULL;
-  EXPECT_TRUE(
-      GetModuleHandleEx(0, safe_browsing::kTestDllNames[0], &module_handle));
+  HMODULE module_handle = GetModuleHandle(safe_browsing::kTestDllNames[0]);

[robertshield, 2014/08/15 01:16:34]

Nice find! Instead of this, please use GetModuleHandleEx with
GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT as the first param to make it
explicit that we do not desire to change the refcount.

+  EXPECT_NE(reinterpret_cast<HANDLE>(NULL), module_handle);
   uint8_t* export_addr = reinterpret_cast<uint8_t*>(
       GetProcAddress(module_handle, safe_browsing::kTestExportName));
   EXPECT_NE(reinterpret_cast<uint8_t*>(NULL), export_addr);
 
   uint8_t new_val = (*export_addr) + 1;
   SIZE_T bytes_written = 0;
   WriteProcessMemory(GetCurrentProcess(),
                      export_addr,
                      reinterpret_cast<void*>(&new_val),
                      1,
@@ skipping 14 matching lines @@
   EXPECT_EQ(base::WideToUTF8(std::wstring(safe_browsing::kTestDllNames[0])),
             process_report.module_state(0).name());
   EXPECT_EQ(
       safe_browsing::ClientIncidentReport_EnvironmentData_Process_ModuleState::
           MODULE_STATE_MODIFIED,
       process_report.module_state(0).modified_state());
   EXPECT_EQ(1, process_report.module_state(0).modified_export_size());
   EXPECT_EQ(std::string(safe_browsing::kTestExportName),
             process_report.module_state(0).modified_export(0));
 }