Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 471063002: Guard ANGLE and MESA instead of defining them as native when unsupported. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Guard ANGLE and MESA instead of defining them as native when unsupported. Since we've added "angle" to the default list of configs we've been running kNative_GLContextType tests twice in DM, once for the real native, once for angle. This pointlessly doubles the GPU critical path in DM. Whoops. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/60c7707958a542112add1dcb246cdf9135dda870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M dm/DM.cpp View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein_C
6 years, 4 months ago (2014-08-14 16:47:34 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-14 16:48:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/471063002/1
6 years, 4 months ago (2014-08-14 16:49:10 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-14 16:49:11 UTC) #4
bsalomon
lgtm
6 years, 4 months ago (2014-08-14 17:35:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 17:37:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 60c7707958a542112add1dcb246cdf9135dda870

Powered by Google App Engine
This is Rietveld 408576698