Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: dm/DM.cpp

Issue 471063002: Guard ANGLE and MESA instead of defining them as native when unsupported. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 081c0f05e17c486939d0d16083ce97890e827172..09f0ce8f268cd0b15e0cd16a3012fd4e19148741 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -63,20 +63,14 @@ static SkString lowercase(SkString s) {
}
static const GrContextFactory::GLContextType native = GrContextFactory::kNative_GLContextType;
-static const GrContextFactory::GLContextType nvpr = GrContextFactory::kNVPR_GLContextType;
+static const GrContextFactory::GLContextType nvpr = GrContextFactory::kNVPR_GLContextType;
static const GrContextFactory::GLContextType null = GrContextFactory::kNull_GLContextType;
static const GrContextFactory::GLContextType debug = GrContextFactory::kDebug_GLContextType;
-static const GrContextFactory::GLContextType angle =
#if SK_ANGLE
-GrContextFactory::kANGLE_GLContextType;
-#else
-native;
+static const GrContextFactory::GLContextType angle = GrContextFactory::kANGLE_GLContextType;
#endif
-static const GrContextFactory::GLContextType mesa =
#if SK_MESA
-GrContextFactory::kMESA_GLContextType;
-#else
-native;
+static const GrContextFactory::GLContextType mesa = GrContextFactory::kMESA_GLContextType;
#endif
static void kick_off_gms(const SkTDArray<GMRegistry::Factory>& gms,
@@ -101,8 +95,12 @@ static void kick_off_gms(const SkTDArray<GMRegistry::Factory>& gms,
START("nvprmsaa16", GpuGMTask, expectations, nvpr, gpuAPI, 16);
START("gpunull", GpuGMTask, expectations, null, gpuAPI, 0);
START("gpudebug", GpuGMTask, expectations, debug, gpuAPI, 0);
+#if SK_ANGLE
START("angle", GpuGMTask, expectations, angle, gpuAPI, 0);
+#endif
+#if SK_MESA
START("mesa", GpuGMTask, expectations, mesa, gpuAPI, 0);
+#endif
START("pdf", PDFTask, RASTERIZE_PDF_PROC);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698