Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/test/data/extensions/api_test/extension_options/embed_self/test.js

Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Run formatter and make the WebUI test also use LoadExtension Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/extension_options/embed_self/options.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
diff --git a/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js b/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
index 69a8a6999fc211df288b7d9b20f1f7500b0b034a..6c0e3a436221107b5a9a8e5546f7c7bdac5c05d0 100644
--- a/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
+++ b/chrome/test/data/extensions/api_test/extension_options/embed_self/test.js
@@ -136,5 +136,28 @@ chrome.test.runTests([
};
document.body.appendChild(extensionoptions);
+ },
+
+ function externalLinksOpenInNewTab() {
+ var done = chrome.test.listenForever(chrome.runtime.onMessage,
+ function(message, sender, sendResponse) {
+ if (message == 'ready') {
+ sendResponse('externalLinksOpenInNewTab');
+ } else if (message == 'done') {
+ try {
+ chrome.tabs.query({url: 'http://www.chromium.org/'}, function(tabs) {
+ chrome.test.assertEq(1, tabs.length);
+ chrome.test.assertEq('http://www.chromium.org/', tabs[0].url);
+ done();
+ });
+ } finally {
+ document.body.removeChild(extensionoptions);
+ }
+ }
+ });
+
+ var extensionoptions = document.createElement('extensionoptions');
+ extensionoptions.setAttribute('extension', chrome.runtime.id);
+ document.body.appendChild(extensionoptions);
}
]);
« no previous file with comments | « chrome/test/data/extensions/api_test/extension_options/embed_self/options.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698