chrome/test/data/extensions/api_test/extension_options/embed_self/options.js - Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/extension_options/embed_self/options.js

Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Run formatter and make the WebUI test also use LoadExtension Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/extension_options/embed_self/options.html ('k') | chrome/test/data/extensions/api_test/extension_options/embed_self/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/extension_options/embed_self/options.js

diff --git a/chrome/test/data/extensions/api_test/extension_options/embed_self/options.js b/chrome/test/data/extensions/api_test/extension_options/embed_self/options.js

index 7872de4bd5072695e6198f4856e86772d244def4..3481b47fe1b11bc65ecd29a16bacd0b267b4fe0f 100644

--- a/chrome/test/data/extensions/api_test/extension_options/embed_self/options.js

+++ b/chrome/test/data/extensions/api_test/extension_options/embed_self/options.js

@@ -44,5 +44,14 @@ chrome.runtime.sendMessage('ready', function(command) {

});

+ break;

+ case 'externalLinksOpenInNewTab':

+ var link = document.getElementById('link');

+ chrome.test.runWithUserGesture(function() {

+ link.click();

+ chrome.runtime.sendMessage('done');

+ }.bind(link));

}

});