Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: gm/rebaseline_server/static/live-loader.js

Issue 471033003: Fixing broken images (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/live-loader.js
diff --git a/gm/rebaseline_server/static/live-loader.js b/gm/rebaseline_server/static/live-loader.js
index c2cb01f4df76a2ae400efbc615920d05991b9cf3..09205df6a277c915dee2fbc8d37a06a07d6620dc 100644
--- a/gm/rebaseline_server/static/live-loader.js
+++ b/gm/rebaseline_server/static/live-loader.js
@@ -1040,28 +1040,9 @@ Loader.controller(
var v = parseInt(brightnessString);
return $scope.hexColorString(v, v, v);
};
-
- /**
- * Returns the last path component of image diff URL for a given ImagePair.
- *
- * Depending on which diff this is (whitediffs, pixeldiffs, etc.) this
- * will be relative to different base URLs.
- *
- * We must keep this function in sync with _get_difference_locator() in
- * ../imagediffdb.py
- *
- * @param imagePair: ImagePair to generate image diff URL for
- */
// TODO (stephana): this is a temporary fix. A fix is in the works
epoger 2014/08/14 18:06:35 delete the TODO! Hooray!
stephana 2014/08/14 18:28:22 Acknowledged.
// to get rid of this function and include the URL in the data
// sent from the backend.
- $scope.getImageDiffRelativeUrl = function(imagePair) {
- var before =
- imagePair[constants.KEY__IMAGEPAIRS__IMAGE_A_URL] + "_png-vs-" +
- imagePair[constants.KEY__IMAGEPAIRS__IMAGE_B_URL] + "_png";
- return before.replace(/[^\w\-]/g, "_") + ".png";
- };
-
}
);

Powered by Google App Engine
This is Rietveld 408576698