chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm - Issue 471023003: Make sure the new confirmation bubble is always shown upon signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

Issue 471023003: Make sure the new confirmation bubble is always shown upon signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: roger's comments addressed and rebased Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

index 47b7389269aee4aad38405c500d97356360855d2..ed4cb23218c17b5f655d6cea6e61304324c22b45 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

@@ -71,7 +71,8 @@ class ProfileChooserControllerTest : public CocoaProfileTest {

controller_.reset([[ProfileChooserController alloc]

initWithBrowser:browser()

anchoredAt:point

- withMode:profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER

+ withViewMode:profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER

+ withTutorialMode:profiles::TUTORIAL_MODE_NONE

Alexei Svitkine (slow) 2014/08/15 15:51:47 Nit: ObjC style is to actually only include "with"

guohui 2014/08/15 16:06:59 Done.

withServiceType:signin::GAIA_SERVICE_TYPE_NONE]);

[controller_ showWindow:nil];

}