chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm - Issue 471023003: Make sure the new confirmation bubble is always shown upon signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 471023003: Make sure the new confirmation bubble is always shown upon signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: roger's comments addressed and rebased Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

index b94e3f46d6005b34f086516cd492b84fc4068ae1..90489e62b85f99ce9e046cc2877221906ffc15c3 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

@@ -944,7 +944,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,

- (id)initWithBrowser:(Browser*)browser

anchoredAt:(NSPoint)point

- withMode:(profiles::BubbleViewMode)mode

+ withViewMode:(profiles::BubbleViewMode)viewMode

+ withTutorialMode:(profiles::TutorialMode)tutorialMode

withServiceType:(signin::GAIAServiceType)serviceType {

base::scoped_nsobject<InfoBubbleWindow> window([[InfoBubbleWindow alloc]

initWithContentRect:ui::kWindowSizeDeterminedLater

@@ -956,8 +957,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,

parentWindow:browser->window()->GetNativeWindow()

anchoredAt:point])) {

browser_ = browser;

- viewMode_ = mode;

- tutorialMode_ = profiles::TUTORIAL_MODE_NONE;

+ viewMode_ = viewMode;

+ tutorialMode_ = tutorialMode;

observer_.reset(new ActiveProfileObserverBridge(self, browser_));

serviceType_ = serviceType;