chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm - Issue 471023003: Make sure the new confirmation bubble is always shown upon signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

Issue 471023003: Make sure the new confirmation bubble is always shown upon signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: roger's comments addressed and rebased Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

index ed47b092ba974816e1d92fa59403f632aa01ed66..a28c553e787d2a104518d3d6f166af50ec8a5dc9 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

@@ -165,12 +165,15 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,

// |menuController_| will automatically release itself on close.

if (switches::IsNewAvatarMenu()) {

- profiles::BubbleViewMode viewMode =

- profiles::BubbleViewModeFromAvatarBubbleMode(mode);

+ profiles::BubbleViewMode viewMode;

+ profiles::TutorialMode tutorialMode;

+ profiles::BubbleViewModeFromAvatarBubbleMode(

+ mode, &viewMode, &tutorialMode);

menuController_ =

[[ProfileChooserController alloc] initWithBrowser:browser_

anchoredAt:point

- withMode:viewMode

+ withViewMode:viewMode

+ withTutorialMode:tutorialMode

withServiceType:serviceType];

} else {

menuController_ =