Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 470943002: Fix cpplint warnings. (Closed)

Created:
6 years, 4 months ago by simonb (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Anton, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix cpplint warnings. Fixes: base/android/linker/linker_jni.cc:300: Single-parameter constructors should be marked explicit. [runtime/explicit] [5] base/android/linker/linker_jni.cc:313: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] base/android/linker/linker_jni.cc:319: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] base/android/linker/linker_jni.cc:320: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M base/android/linker/linker_jni.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
simonb (inactive)
6 years, 4 months ago (2014-08-14 10:14:54 UTC) #1
Anton
On 2014/08/14 10:14:54, simonb wrote: lgtm, though I am not a committer so you will ...
6 years, 4 months ago (2014-08-14 10:19:49 UTC) #2
simonb (inactive)
For owner/committer review. Thanks.
6 years, 4 months ago (2014-08-14 10:34:35 UTC) #3
rmcilroy
On 2014/08/14 10:34:35, simonb wrote: > For owner/committer review. Thanks. lgtm, thanks.
6 years, 4 months ago (2014-08-14 12:08:30 UTC) #4
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 4 months ago (2014-08-14 12:40:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/470943002/1
6 years, 4 months ago (2014-08-14 12:43:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 17:29:25 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 17:45:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 289642

Powered by Google App Engine
This is Rietveld 408576698