Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3250)

Unified Diff: base/android/linker/linker_jni.cc

Issue 470943002: Fix cpplint warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/linker/linker_jni.cc
diff --git a/base/android/linker/linker_jni.cc b/base/android/linker/linker_jni.cc
index be4a5ed30df2c3b6ca99830020bb11835153200b..b0b464b0d4eb8f2d1fb6292eccf89387959ac241 100644
--- a/base/android/linker/linker_jni.cc
+++ b/base/android/linker/linker_jni.cc
@@ -297,7 +297,7 @@ bool FileLibraryOpener::Open(
// Used for opening the library in a zip file.
class ZipLibraryOpener {
public:
- ZipLibraryOpener(const char* zip_file) : zip_file_(zip_file) {}
+ explicit ZipLibraryOpener(const char* zip_file) : zip_file_(zip_file) {}
bool Open(
crazy_library_t** library,
const char* library_name,
@@ -310,14 +310,14 @@ bool ZipLibraryOpener::Open(
crazy_library_t** library,
const char* library_name,
crazy_context_t* context) const {
- if (!crazy_library_open_in_zip_file(
- library, zip_file_, library_name, context)) {
- LOG_ERROR("%s: Could not open %s in zip file %s: %s",
- __FUNCTION__, library_name, zip_file_,
- crazy_context_get_error(context));
- return false;
- }
- return true;
+ if (!crazy_library_open_in_zip_file(
+ library, zip_file_, library_name, context)) {
+ LOG_ERROR("%s: Could not open %s in zip file %s: %s",
+ __FUNCTION__, library_name, zip_file_,
+ crazy_context_get_error(context));
+ return false;
+ }
+ return true;
}
} // unnamed namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698