Issue 470923005: Reland: Update iOS deployment target to 7.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 470923005: Reland: Update iOS deployment target to 7.0 (Closed)

Created:
6 years, 4 months ago by stuartmorgan

Modified:
6 years, 4 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, rohitrao (ping after 24h)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland: Update iOS deployment target to 7.0 iOS 6 will no longer be supported. Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a ceilf since according to the internet, the former rounds up, and the latter does not) to fix compilation. Special-cases the nil font case, since sizeWithFont:nil would work and return zero, but it's impossible to construct an attribute dictionary with a nil font. BUG=402921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289702

Patch Set 1 #

Patch Set 2 : Fix nil font handling #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
M	build/common.gypi	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/gfx/platform_font_ios.mm	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	ui/gfx/text_utils_ios.mm	View	1	1 chunk	+4 lines, -1 line	0 comments	Download