Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 470913002: Revert 23058 - "Allow externalizing cons and sliced string." (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert 23058 - "Allow externalizing cons and sliced string." Reason for revert: broke inspector | Fulfill overdue TODO. | | R=mstarzinger@chromium.org | | Review URL: https://codereview.chromium.org/460643002 TBR=yangguo@chromium.org,mstarzinger@chromium.org BUG=403521 LOG=n Committed: https://code.google.com/p/v8/source/detail?r=23115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/api.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-08-14 08:40:06 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 manually as 23115 (presubmit successful).
6 years, 4 months ago (2014-08-14 08:40:18 UTC) #2
Yang
6 years, 4 months ago (2014-08-14 08:40:34 UTC) #3
Message was sent while issue was closed.
On 2014/08/14 08:40:18, jochen (slow - soon OOO) wrote:
> Committed patchset #1 manually as 23115 (presubmit successful).

LGTM.

Powered by Google App Engine
This is Rietveld 408576698