Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 460643002: Allow externalizing cons and sliced string. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Allow externalizing cons and sliced string. Fulfill overdue TODO. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23058 Committed: https://code.google.com/p/v8/source/detail?r=23826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/api.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 4 months ago (2014-08-11 12:28:23 UTC) #1
Michael Starzinger
LGTM.
6 years, 4 months ago (2014-08-11 16:12:02 UTC) #2
Yang
Committed patchset #1 manually as 23058 (presubmit successful).
6 years, 4 months ago (2014-08-11 19:38:07 UTC) #3
Yang
On 2014/08/11 19:38:07, Yang wrote: > Committed patchset #1 manually as 23058 (presubmit successful). Needs ...
6 years, 4 months ago (2014-08-22 12:06:48 UTC) #4
Yang
6 years, 3 months ago (2014-09-10 08:47:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698