Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 470903003: Remove CSSParserValue::createCSSValue and unused callers (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pp4
Project:
blink
Visibility:
Public.

Description

Remove CSSParserValue::createCSSValue and unused callers The function CSSParserValue::createCSSValue is only actually used by calc parsing, although we can more easily do the same thing there in much less code. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180325

Patch Set 1 #

Patch Set 2 : fix forward decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -121 lines) Patch
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSFunctionValue.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSFunctionValue.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/CSSValueList.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.cpp View 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Timothy Loh
(depends on moving files to core/css/parser, https://codereview.chromium.org/469183002/)
6 years, 4 months ago (2014-08-14 08:36:35 UTC) #1
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-14 17:27:37 UTC) #2
eseidel
lgtm
6 years, 4 months ago (2014-08-14 17:27:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/470903003/1
6 years, 4 months ago (2014-08-14 17:28:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 17:28:59 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/css/CSSFunctionValue.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-14 17:29:00 UTC) #6
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-15 00:08:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/470903003/1
6 years, 4 months ago (2014-08-15 00:09:07 UTC) #8
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-15 00:41:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/470903003/40001
6 years, 4 months ago (2014-08-15 00:43:23 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-15 03:11:21 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 04:12:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (40001) as 180325

Powered by Google App Engine
This is Rietveld 408576698