Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: Source/core/css/CSSFunctionValue.cpp

Issue 470903003: Remove CSSParserValue::createCSSValue and unused callers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pp4
Patch Set: fix forward decl Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSFunctionValue.h ('k') | Source/core/css/CSSValueList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/css/CSSFunctionValue.h" 27 #include "core/css/CSSFunctionValue.h"
28 28
29 #include "core/css/CSSValueList.h" 29 #include "core/css/CSSValueList.h"
30 #include "core/css/parser/CSSParserValues.h"
31 #include "wtf/text/StringBuilder.h" 30 #include "wtf/text/StringBuilder.h"
32 31
33 namespace blink { 32 namespace blink {
34 33
35 CSSFunctionValue::CSSFunctionValue(CSSParserFunction* function)
36 : CSSValue(FunctionClass)
37 , m_name(function->name)
38 {
39 if (function->args)
40 m_args = CSSValueList::createFromParserValueList(function->args.get());
41 }
42
43 CSSFunctionValue::CSSFunctionValue(String name, PassRefPtrWillBeRawPtr<CSSValueL ist> args) 34 CSSFunctionValue::CSSFunctionValue(String name, PassRefPtrWillBeRawPtr<CSSValueL ist> args)
44 : CSSValue(FunctionClass) 35 : CSSValue(FunctionClass)
45 , m_name(name) 36 , m_name(name)
46 , m_args(args) 37 , m_args(args)
47 { 38 {
48 } 39 }
49 40
50 String CSSFunctionValue::customCSSText() const 41 String CSSFunctionValue::customCSSText() const
51 { 42 {
52 StringBuilder result; 43 StringBuilder result;
53 result.append(m_name); // Includes the '(' 44 result.append(m_name); // Includes the '('
54 if (m_args) 45 if (m_args)
55 result.append(m_args->cssText()); 46 result.append(m_args->cssText());
56 result.append(')'); 47 result.append(')');
57 return result.toString(); 48 return result.toString();
58 } 49 }
59 50
60 bool CSSFunctionValue::equals(const CSSFunctionValue& other) const 51 bool CSSFunctionValue::equals(const CSSFunctionValue& other) const
61 { 52 {
62 return m_name == other.m_name && compareCSSValuePtr(m_args, other.m_args); 53 return m_name == other.m_name && compareCSSValuePtr(m_args, other.m_args);
63 } 54 }
64 55
65 void CSSFunctionValue::traceAfterDispatch(Visitor* visitor) 56 void CSSFunctionValue::traceAfterDispatch(Visitor* visitor)
66 { 57 {
67 visitor->trace(m_args); 58 visitor->trace(m_args);
68 CSSValue::traceAfterDispatch(visitor); 59 CSSValue::traceAfterDispatch(visitor);
69 } 60 }
70 61
71 } 62 }
OLDNEW
« no previous file with comments | « Source/core/css/CSSFunctionValue.h ('k') | Source/core/css/CSSValueList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698