Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470803006: [Telemetry] Android power moniotrs extend SysfsPowerMonitor. (Closed)

Created:
6 years, 4 months ago by tmandel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Android power monitors extend SysfsPowerMonitor. Adjusted DS2784PowerMonitor, DumpsysPowerMonitor, and MonsoonPowerMonitor to extend SysfsPowerMonitor to get CPU data. Also cleaned up a little bit of SysfsPowerMonitor. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291230

Patch Set 1 #

Total comments: 8

Patch Set 2 : Moved platform files and made other Android monitors extend sysfs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -180 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 1 chunk +1 line, -1 line 0 comments Download
A tools/telemetry/telemetry/core/platform/android_sysfs_platform.py View 1 1 chunk +43 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/android_sysfs_platform_unittest.py View 1 1 chunk +33 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/cros_sysfs_platform.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/platform/cros_sysfs_platform_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 1 4 chunks +10 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 2 chunks +16 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py View 1 4 chunks +4 lines, -24 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py View 1 1 chunk +0 lines, -49 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform_unittest.py View 1 1 chunk +0 lines, -38 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor.py View 1 5 chunks +11 lines, -5 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py View 1 1 chunk +0 lines, -34 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 1 5 chunks +26 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/sysfs_platform.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tmandel
Please have a look. This has Android devices with the DS2784 Fuel Gauge gather frequency ...
6 years, 4 months ago (2014-08-19 21:00:22 UTC) #1
tonyg
https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py#newcode22 tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py:22: class DS2784PowerMonitor(sysfs_power_monitor.SysfsPowerMonitor): Perhaps all android power monitors should extend ...
6 years, 4 months ago (2014-08-20 02:41:36 UTC) #2
tbroch1
https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_sysfs_platform.py File tools/telemetry/telemetry/core/platform/power_monitor/android_sysfs_platform.py (right): https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_sysfs_platform.py#newcode39 tools/telemetry/telemetry/core/platform/power_monitor/android_sysfs_platform.py:39: state = 'WFI' Yikes! https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode186 ...
6 years, 4 months ago (2014-08-20 17:40:32 UTC) #3
tmandel
I've adjusted the other Android monitors to also gather CPU data. https://codereview.chromium.org/470803006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): ...
6 years, 4 months ago (2014-08-20 22:01:07 UTC) #4
tonyg
lgtm
6 years, 4 months ago (2014-08-21 00:25:46 UTC) #5
tmandel
The CQ bit was checked by tmandel@chromium.org
6 years, 4 months ago (2014-08-21 17:03:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmandel@chromium.org/470803006/40001
6 years, 4 months ago (2014-08-21 17:08:25 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 19:58:37 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:09:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (40001) as 291230

Powered by Google App Engine
This is Rietveld 408576698