Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py

Issue 470803006: [Telemetry] Android power moniotrs extend SysfsPowerMonitor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved platform files and made other Android monitors extend sysfs. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py
index 62c9f1435238da42b62612e232afe52166af19f0..13439eb47a52f1e4a64fb0c467326c25ed00e23d 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py
@@ -9,8 +9,10 @@ import re
from telemetry import decorators
from telemetry.core.platform import power_monitor
+
CPU_PATH = '/sys/devices/system/cpu/'
+
class SysfsPowerMonitor(power_monitor.PowerMonitor):
"""PowerMonitor that relies on sysfs to monitor CPU statistics on several
different platforms.
@@ -34,8 +36,7 @@ class SysfsPowerMonitor(power_monitor.PowerMonitor):
"""
super(SysfsPowerMonitor, self).__init__()
self._browser = None
- self._cpus = filter(lambda x: re.match(r'^cpu[0-9]+', x),
- platform.RunShellCommand('ls %s' % CPU_PATH).split())
+ self._cpus = None
self._final_cstate = None
self._final_freq = None
self._initial_cstate = None
@@ -51,6 +52,9 @@ class SysfsPowerMonitor(power_monitor.PowerMonitor):
assert not self._browser, 'Must call StopMonitoringPower().'
self._browser = browser
if self.CanMonitorPower():
+ self._cpus = filter(
+ lambda x: re.match(r'^cpu[0-9]+', x),
+ self._platform.RunShellCommand('ls %s' % CPU_PATH).split())
self._initial_freq = self.GetCpuFreq()
self._initial_cstate = self.GetCpuState()
@@ -58,7 +62,7 @@ class SysfsPowerMonitor(power_monitor.PowerMonitor):
assert self._browser, 'StartMonitoringPower() not called.'
try:
out = {}
- if self.CanMonitorPower():
+ if SysfsPowerMonitor.CanMonitorPower(self):
self._final_freq = self.GetCpuFreq()
self._final_cstate = self.GetCpuState()
frequencies = SysfsPowerMonitor.ComputeCpuStats(
@@ -162,3 +166,22 @@ class SysfsPowerMonitor(power_monitor.PowerMonitor):
average[state] = time / float(count)
cpu_stats['whole_package'] = average
return cpu_stats
+
+ @staticmethod
+ def CombineResults(cpu_stats, power_stats):
+ """Add frequency and c-state residency data to the power data.
+
+ Args:
+ cpu_stats: Dictionary containing CPU statistics.
+ power_stats: Dictionary containing power statistics.
+
+ Returns:
+ Dictionary in the format returned by StopMonitoringPower.
+ """
+ if not cpu_stats:
+ return power_stats
+ if 'component_utilization' not in power_stats:
+ power_stats['component_utilization'] = {}
+ for cpu in cpu_stats:
+ power_stats['component_utilization'][cpu] = cpu_stats[cpu]
+ return power_stats

Powered by Google App Engine
This is Rietveld 408576698