Bindings: Remove special cases for DOMStringList

Bindings: Remove special cases for DOMStringList

When DOMStringList was added, special cases were also added so that it
could masquerade as sequence<DOMString> and DOMString[] as well, since
those Web IDL types were not supported. Now that Blink IDL understands
sequence<T> and T[] we can remove the special cases.

R=haraken@chromium.org,nbarth@chromium.org
BUG=239771
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161079

[jsbell, 2013-10-30 18:01:12]

haraken@, nbarth@ - please take a look?

https://codereview.chromium.org/47073007/diff/1/Source/bindings/tests/results...
File Source/bindings/tests/results/V8TestCallback.h (left):

https://codereview.chromium.org/47073007/diff/1/Source/bindings/tests/results...
Source/bindings/tests/results/V8TestCallback.h:50: virtual bool
callbackWithStringList(RefPtr<DOMStringList> listParam);
Technically there's no reason to remove this, it has just ceased to be a special
case and we don't have any callbacks that take DOMStringList in non-test code.

I can add it back in.

[Nils Barth (inactive), 2013-10-31 00:59:24]

LGTM (thanks for fixing Python as well!)
Still need ok from haraken -- haraken, presumably this is ok?
(Removes one of the ugly non-wrapper type special cases.)

[Nils Barth (inactive), 2013-10-31 01:18:27]

Just uploaded a revised patch set:
1. Rebased/merges changes following r160994
(Just modified the Python code.)
IDL compiler: 3 more special types for methods
https://codereview.chromium.org/52353003/

2. Remove DOMStringList test cases from TestObjectPython.idl,
since no longer special cases.

(You can do these yourself if you'd prefer, but easy enough here.)

[haraken, 2013-10-31 01:36:03]

LGTM. This looks great!

[commit-bot: I haz the power, 2013-10-31 16:29:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/47073007/60001

[commit-bot: I haz the power, 2013-10-31 16:29:24]

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObject.cpp
  Hunk #1 FAILED at 3811.
  Hunk #2 FAILED at 4136.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObject.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObject.cpp
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp
b/Source/bindings/tests/results/V8TestObject.cpp
index
492528e87c08ed158c30b66065e17f404726a9d1..fbc303e278de39763b4293ff5e42cece7b8de779
100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -3811,7 +3811,7 @@ static void overloadedMethod6Method(const
v8::FunctionCallbackInfo<v8::Value>& a
         return;
     }
     TestObj* imp = V8TestObject::toNative(args.Holder());
-    V8TRYCATCH_VOID(RefPtr<DOMStringList>, listArg, toDOMStringList(args[0],
args.GetIsolate()));
+    V8TRYCATCH_VOID(DOMStringList*, listArg,
V8DOMStringList::HasInstance(args[0], args.GetIsolate(),
worldType(args.GetIsolate())) ?
V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0);
     imp->overloadedMethod(listArg);
 }
 
@@ -4136,7 +4136,7 @@ static void domStringListFunctionMethod(const
v8::FunctionCallbackInfo<v8::Value
     }
     TestObj* imp = V8TestObject::toNative(args.Holder());
     ExceptionState es(args.GetIsolate());
-    V8TRYCATCH_VOID(RefPtr<DOMStringList>, values, toDOMStringList(args[0],
args.GetIsolate()));
+    V8TRYCATCH_VOID(DOMStringList*, values,
V8DOMStringList::HasInstance(args[0], args.GetIsolate(),
worldType(args.GetIsolate())) ?
V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0);
     RefPtr<DOMStringList> result = imp->domStringListFunction(values, es);
     if (es.throwIfNeeded())
         return;

[commit-bot: I haz the power, 2013-10-31 17:10:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/47073007/180001

[commit-bot: I haz the power, 2013-10-31 19:00:16]

Change committed as 161079