Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: Source/bindings/scripts/unstable/v8_types.py

Issue 47073007: Bindings: Remove special cases for DOMStringList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/idls/TestCallback.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/unstable/v8_types.py
diff --git a/Source/bindings/scripts/unstable/v8_types.py b/Source/bindings/scripts/unstable/v8_types.py
index 8d4d03186bc91a8c79133f1b77fa9773d8c013eb..b2e089e2e5579914876d117f7f53c29658fe26b6 100644
--- a/Source/bindings/scripts/unstable/v8_types.py
+++ b/Source/bindings/scripts/unstable/v8_types.py
@@ -263,7 +263,6 @@ def cpp_type(idl_type, extended_attributes=None, used_as_argument=False):
if idl_type in CPP_SPECIAL_CONVERSION_RULES:
return CPP_SPECIAL_CONVERSION_RULES[idl_type]
if (idl_type in NON_WRAPPER_TYPES or
- idl_type == 'DOMStringList' or # FIXME: eliminate this special case
idl_type == 'XPathNSResolver'): # FIXME: eliminate this special case
return 'RefPtr<%s>' % idl_type
if idl_type == 'DOMString':
@@ -358,7 +357,6 @@ V8_VALUE_TO_CPP_VALUE_AND_INCLUDES = {
set()),
'Dictionary': ('Dictionary({v8_value}, {isolate})',
set(['bindings/v8/Dictionary.h'])),
- 'DOMStringList': ('toDOMStringList({v8_value}, {isolate})', set()),
'MediaQueryListListener': (
'MediaQueryListListener::create(ScriptValue({v8_value}, {isolate}))',
set(['core/css/MediaQueryListListener.h'])),
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/idls/TestCallback.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698