Revert of Fix Mac sandbox meta data access (reland)

Revert of Fix Mac sandbox meta data access (reland) (patchset #2 of https://codereview.chromium.org/469383002/)

Reason for revert:
Caused GPU crashes on Mac10.6 Blink layout tests running with component=shared_library.

Original issue's description:
> Fix Mac sandbox meta data access (reland)
> 
> We currently allow all metadata access due to
> https://codereview.chromium.org/10539009/ made the for loop comparison
> in Sandbox::AllowMetadataForPath() always false, when we actually only
> want to allow access to the path and all its parent path until root.
> 
> Turn the for loop to a do/while loop instead as it's a better fit, also
> add a test case for Sandbox::AllowMetadataForPath().
> 
> We also need file read meta data access to all the .dylibs we linked to.
> 
> It should only affect component builds on OS X 10.6 and utility process
> as no other process is using this mechanism.
> 
> BUG=403801
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289738

TBR=avi@chromium.org,jeremy@chromium.org,thakis@chromium.org,jiangj@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=403801
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289877

[adamk, 2014-08-15 15:38:34]

Created Revert of Fix Mac sandbox meta data access (reland)

[Nico, 2014-08-15 15:39:23]

link to bot?


On Fri, Aug 15, 2014 at 8:38 AM, <adamk@chromium.org> wrote:

> Reviewers: Avi, jeremy, Nico (very away), Jiang,
>
> Message:
> Created Revert of Fix Mac sandbox meta data access (reland)
>
> Description:
> Revert of Fix Mac sandbox meta data access (reland) (patchset #2 of
> https://codereview.chromium.org/469383002/)
>
> Reason for revert:
> Caused GPU crashes on Mac10.6 Blink layout tests running with
> component=shared_library.
>
> Original issue's description:
>
>> Fix Mac sandbox meta data access (reland)
>>
>
>  We currently allow all metadata access due to
>> https://codereview.chromium.org/10539009/ made the for loop comparison
>> in Sandbox::AllowMetadataForPath() always false, when we actually only
>> want to allow access to the path and all its parent path until root.
>>
>
>  Turn the for loop to a do/while loop instead as it's a better fit, also
>> add a test case for Sandbox::AllowMetadataForPath().
>>
>
>  We also need file read meta data access to all the .dylibs we linked to.
>>
>
>  It should only affect component builds on OS X 10.6 and utility process
>> as no other process is using this mechanism.
>>
>
>  BUG=403801
>>
>
>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>> revision=289738
>>
>
> TBR=avi@chromium.org,jeremy@chromium.org,thakis@chromium.org,
> jiangj@opera.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=403801
>
> Please review this at https://codereview.chromium.org/470693004/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+5, -35 lines):
>   M content/common/sandbox_mac.h
>   M content/common/sandbox_mac.mm
>   M content/common/sandbox_mac_diraccess_unittest.mm
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-08-15 15:42:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/adamk@chromium.org/470693004/1

[adamk, 2014-08-15 15:43:39]

Last green run:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28db...
First red run:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28db...

[commit-bot: I haz the power, 2014-08-15 15:47:56]

Committed patchset #1 (1) as 289877