Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 470643002: Add metrics to the new ProfileChooser Tutorials (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename first run to upgrade; other nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index a060e297211c1d1e00ae8ecc09048f89d0981a96..5c635130fb9d89a2b9686338f08c66b7f38e0691 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -900,35 +900,49 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
- (IBAction)seeWhatsNew:(id)sender {
chrome::ShowUserManagerWithTutorial(
profiles::USER_MANAGER_TUTORIAL_OVERVIEW);
+ ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_WHATS_NEW);
}
- (IBAction)showSwitchUserView:(id)sender {
[self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_SWITCH_USER];
+ ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_NOT_YOU);
}
- (IBAction)configureSyncSettings:(id)sender {
tutorialMode_ = profiles::TUTORIAL_MODE_NONE;
LoginUIServiceFactory::GetForProfile(browser_->profile())->
SyncConfirmationUIClosed(true);
+ ProfileMetrics::LogProfileDesktopSignin(
+ ProfileMetrics::PROFILE_DESKTOP_SIGNIN_SETTINGS);
}
- (IBAction)syncSettingsConfirmed:(id)sender {
tutorialMode_ = profiles::TUTORIAL_MODE_NONE;
LoginUIServiceFactory::GetForProfile(browser_->profile())->
SyncConfirmationUIClosed(false);
+ ProfileMetrics::LogProfileDesktopSignin(
+ ProfileMetrics::PROFILE_DESKTOP_SIGNIN_OK);
[self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER];
}
- (IBAction)addPerson:(id)sender {
profiles::ShowUserManagerMaybeWithTutorial(browser_->profile());
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_ADD_PERSON);
}
- (IBAction)disconnectProfile:(id)sender {
chrome::ShowSettings(browser_);
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_DISCONNECT);
}
- (IBAction)navigateBackFromSwitchUserView:(id)sender {
[self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER];
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_BACK);
}
- (void)windowWillClose:(NSNotification*)notification {
@@ -1147,6 +1161,9 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
}
- (NSView*)buildSigninConfirmationView {
+ ProfileMetrics::LogProfileDesktopSignin(
+ ProfileMetrics::PROFILE_DESKTOP_SIGNIN_VIEW);
+
NSString* titleMessage = l10n_util::GetNSString(
IDS_PROFILES_CONFIRM_SIGNIN_TUTORIAL_TITLE);
NSString* contentMessage = l10n_util::GetNSString(
@@ -1190,6 +1207,9 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
prefs::kProfileAvatarTutorialShown, showCount + 1);
}
+ ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_VIEW);
+
NSString* titleMessage = l10n_util::GetNSStringF(
IDS_PROFILES_WELCOME_UPGRADE_TUTORIAL_TITLE, avatarItem.name);
NSString* contentMessage = l10n_util::GetNSString(
@@ -1772,6 +1792,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
- (NSView*)buildSwitchUserView {
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_VIEW);
base::scoped_nsobject<NSView> container(
[[NSView alloc] initWithFrame:NSZeroRect]);
CGFloat availableWidth =

Powered by Google App Engine
This is Rietveld 408576698