Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 470643002: Add metrics to the new ProfileChooser Tutorials (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename first run to upgrade; other nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index 0ab3fbba1d04c666dba53e91c3fd8732a3d75367..3aee1827ad8199980cb8754afc9266d801cc3dc2 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -642,6 +642,8 @@ void ProfileChooserView::ShowView(profiles::BubbleViewMode view_to_display,
case profiles::BUBBLE_VIEW_MODE_SWITCH_USER:
layout = CreateSingleColumnLayout(this, kFixedSwitchUserViewWidth);
sub_view = CreateSwitchUserView(active_item);
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_VIEW);
break;
default:
layout = CreateSingleColumnLayout(this, kFixedMenuWidth);
@@ -690,7 +692,11 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,
SyncConfirmationUIClosed(false /* configure_sync_first */);
tutorial_mode_ = profiles::TUTORIAL_MODE_NONE;
ShowView(profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER, avatar_menu_.get());
+ ProfileMetrics::LogProfileDesktopSignin(
+ ProfileMetrics::PROFILE_DESKTOP_SIGNIN_OK);
} else if (sender == tutorial_see_whats_new_button_) {
+ ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_WHATS_NEW);
chrome::ShowUserManagerWithTutorial(
profiles::USER_MANAGER_TUTORIAL_OVERVIEW);
} else if (sender == remove_account_button_) {
@@ -716,11 +722,17 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,
} else if (sender == signin_current_profile_link_) {
ShowView(profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN, avatar_menu_.get());
} else if (sender == add_person_button_) {
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_ADD_PERSON);
profiles::ShowUserManagerMaybeWithTutorial(browser_->profile());
} else if (sender == disconnect_button_) {
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_DISCONNECT);
chrome::ShowSettings(browser_);
} else if (sender == switch_user_cancel_button_) {
ShowView(profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER, avatar_menu_.get());
+ ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileMetrics::PROFILE_AVATAR_MENU_NOT_YOU_BACK);
} else {
// Either one of the "other profiles", or one of the profile accounts
// buttons was pressed.
@@ -779,8 +791,12 @@ void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {
LoginUIServiceFactory::GetForProfile(browser_->profile())->
SyncConfirmationUIClosed(true /* configure_sync_first */);
tutorial_mode_ = profiles::TUTORIAL_MODE_NONE;
+ ProfileMetrics::LogProfileDesktopSignin(
+ ProfileMetrics::PROFILE_DESKTOP_SIGNIN_SETTINGS);
} else {
DCHECK(sender == tutorial_not_you_link_);
+ ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_NOT_YOU);
ShowView(profiles::BUBBLE_VIEW_MODE_SWITCH_USER, avatar_menu_.get());
}
}
@@ -1413,6 +1429,9 @@ views::View* ProfileChooserView::CreateWelcomeUpgradeTutorialViewIfNeeded(
prefs::kProfileAvatarTutorialShown, show_count + 1);
}
+ ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_VIEW);
+
return CreateTutorialView(
profiles::TUTORIAL_MODE_WELCOME_UPGRADE,
l10n_util::GetStringFUTF16(
@@ -1427,6 +1446,9 @@ views::View* ProfileChooserView::CreateWelcomeUpgradeTutorialViewIfNeeded(
}
views::View* ProfileChooserView::CreateSigninConfirmationView(){
+ ProfileMetrics::LogProfileDesktopSignin(
+ ProfileMetrics::PROFILE_DESKTOP_SIGNIN_VIEW);
+
return CreateTutorialView(
profiles::TUTORIAL_MODE_CONFIRM_SIGNIN,
l10n_util::GetStringUTF16(IDS_PROFILES_CONFIRM_SIGNIN_TUTORIAL_TITLE),

Powered by Google App Engine
This is Rietveld 408576698