Chromium Code Reviews| Index: chrome/browser/profiles/profile_metrics.h |
| diff --git a/chrome/browser/profiles/profile_metrics.h b/chrome/browser/profiles/profile_metrics.h |
| index 99ec02f48e18deb967f03a20d3e358fd3635eea7..f4b85ceb2ec7748d514d75886a205f12f6425643 100644 |
| --- a/chrome/browser/profiles/profile_metrics.h |
| +++ b/chrome/browser/profiles/profile_metrics.h |
| @@ -143,6 +143,47 @@ class ProfileMetrics { |
| }; |
| #endif // defined(OS_ANDROID) |
| + // Enum for tracking user interactions with the signin bubble that appears |
|
msw
2014/08/14 20:42:03
nit: remove redundant "signin", as per "upon signi
Mike Lerman
2014/08/14 20:58:30
Done.
|
| + // in the New Avatar Menu upon signin. This bubble appears after the user |
| + // signs in using the Inline Signin flow. |
| + enum ProfileDesktopSignin { |
|
msw
2014/08/14 20:42:03
nit: Is noting Desktop important? Maybe just note
Mike Lerman
2014/08/14 20:58:30
Done. I went with ProfileNewAvatarMenuSignin to be
|
| + // User viewed the signin bubble after successfully using the inline signin. |
| + PROFILE_DESKTOP_SIGNIN_VIEW = 0, |
| + // User selected ok to dismiss the signin bubble. |
| + PROFILE_DESKTOP_SIGNIN_OK, |
| + // User opened the settings from the signin bubble. |
| + PROFILE_DESKTOP_SIGNIN_SETTINGS, |
| + NUM_PROFILE_DESKTOP_SIGNIN_METRICS, |
| + }; |
| + |
| + // Enum for tracking user interactions with the bubble that appears for all |
| + // users in the new avatar menu after upgrading. |
| + enum ProfileNewAvatarMenuUpgrade { |
| + // User views the upgrade bubble. |
| + PROFILE_AVATAR_MENU_UPGRADE_VIEW, |
|
msw
2014/08/14 20:42:03
nit: = 0
Mike Lerman
2014/08/14 20:58:30
Done.
|
| + // User dismissed the upgrade bubble. |
| + PROFILE_AVATAR_MENU_UPGRADE_DISMISS, |
| + // User selects 'What's New' in the upgrade bubble. |
| + PROFILE_AVATAR_MENU_UPGRADE_WHATS_NEW, |
| + // User selects 'Not You?' in the upgrade bubble. |
| + PROFILE_AVATAR_MENU_UPGRADE_NOT_YOU, |
| + NUM_PROFILE_AVATAR_MENU_UPGRADE_METRICS, |
| + }; |
| + |
| + // Enum for tracking user interactions with the Not You? bubble that users |
|
msw
2014/08/14 20:42:03
nit: 'Not You?' like above; here and in the entrie
Mike Lerman
2014/08/14 20:58:30
Done.
|
| + // can navigate to from the Upgrade bubble after upgrade. |
| + enum ProfileNewAvatarMenuNotYou { |
| + // User views the Not You? bubble. |
| + PROFILE_AVATAR_MENU_NOT_YOU_VIEW, |
|
msw
2014/08/14 20:42:03
nit: = 0
Mike Lerman
2014/08/14 20:58:30
Done.
|
| + // User selects back from within the Not You? bubble. |
| + PROFILE_AVATAR_MENU_NOT_YOU_BACK, |
| + // User adds a person from within the Not You? bubble. |
| + PROFILE_AVATAR_MENU_NOT_YOU_ADD_PERSON, |
| + // User chooses to disconnect (sign out) from within the Not You? bubble. |
| + PROFILE_AVATAR_MENU_NOT_YOU_DISCONNECT, |
| + NUM_PROFILE_AVATAR_MENU_NOT_YOU_METRICS, |
| + }; |
| + |
| static void UpdateReportedProfilesStatistics(ProfileManager* manager); |
| // Count and return summary information about the profiles currently in the |
| // |manager|. This information is returned in the output variable |counts|. |
| @@ -161,6 +202,10 @@ class ProfileMetrics { |
| static void LogProfileDesktopMenu(ProfileDesktopMenu metric, |
| signin::GAIAServiceType gaia_service); |
| static void LogProfileDelete(bool profile_was_signed_in); |
| + static void LogProfileDesktopSignin(ProfileDesktopSignin metric); |
| + static void LogProfileNewAvatarMenuUpgrade( |
| + ProfileNewAvatarMenuUpgrade metric); |
| + static void LogProfileNewAvatarMenuNotYou(ProfileNewAvatarMenuNotYou metric); |
| #if defined(OS_ANDROID) |
| static void LogProfileAndroidAccountManagementMenu( |