Add metrics to the new ProfileChooser Tutorials

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 125 matching lines @@
     // User arrived at the Account management screen, toggled Chrome signout.
     PROFILE_ANDROID_ACCOUNT_MANAGEMENT_MENU_TOGGLE_SIGNOUT,
     // User toggled Chrome signout, and clicked Signout.
     PROFILE_ANDROID_ACCOUNT_MANAGEMENT_MENU_SIGNOUT_SIGNOUT,
     // User toggled Chrome signout, and clicked Cancel.
     PROFILE_ANDROID_ACCOUNT_MANAGEMENT_MENU_SIGNOUT_CANCEL,
     NUM_PROFILE_ANDROID_ACCOUNT_MANAGEMENT_MENU_METRICS,
   };
 #endif  // defined(OS_ANDROID)
 
+  // Enum for tracking user interactions with the signin bubble that appears

[msw, 2014/08/14 20:42:03]

nit: remove redundant "signin", as per "upon signin" below. The two sentences
could could also be combined to be less redundant.

[Mike Lerman, 2014/08/14 20:58:30]

Done.

+  // in the New Avatar Menu upon signin. This bubble appears after the user
+  // signs in using the Inline Signin flow.
+  enum ProfileDesktopSignin {

[msw, 2014/08/14 20:42:03]

nit: Is noting Desktop important? Maybe just note that this is only available
for desktop OSes in the comment and rename this, the histogram and helper
function to something like ProfileNewAvatarSignin.

[Mike Lerman, 2014/08/14 20:58:30]

Done. I went with ProfileNewAvatarMenuSignin to be consistent with the two
histograms below.

+    // User viewed the signin bubble after successfully using the inline signin.
+    PROFILE_DESKTOP_SIGNIN_VIEW = 0,
+    // User selected ok to dismiss the signin bubble.
+    PROFILE_DESKTOP_SIGNIN_OK,
+    // User opened the settings from the signin bubble.
+    PROFILE_DESKTOP_SIGNIN_SETTINGS,
+    NUM_PROFILE_DESKTOP_SIGNIN_METRICS,
+  };
+
+  // Enum for tracking user interactions with the bubble that appears for all
+  // users in the new avatar menu after upgrading.
+  enum ProfileNewAvatarMenuUpgrade {
+    // User views the upgrade bubble.
+    PROFILE_AVATAR_MENU_UPGRADE_VIEW,

[msw, 2014/08/14 20:42:03]

nit: = 0

[Mike Lerman, 2014/08/14 20:58:30]

Done.

+    // User dismissed the upgrade bubble.
+    PROFILE_AVATAR_MENU_UPGRADE_DISMISS,
+    // User selects 'What's New' in the upgrade bubble.
+    PROFILE_AVATAR_MENU_UPGRADE_WHATS_NEW,
+    // User selects 'Not You?' in the upgrade bubble.
+    PROFILE_AVATAR_MENU_UPGRADE_NOT_YOU,
+    NUM_PROFILE_AVATAR_MENU_UPGRADE_METRICS,
+  };
+
+  // Enum for tracking user interactions with the Not You? bubble that users

[msw, 2014/08/14 20:42:03]

nit: 'Not You?' like above; here and in the entries below.

[Mike Lerman, 2014/08/14 20:58:30]

Done.

+  // can navigate to from the Upgrade bubble after upgrade.
+  enum ProfileNewAvatarMenuNotYou {
+    // User views the Not You? bubble.
+    PROFILE_AVATAR_MENU_NOT_YOU_VIEW,

[msw, 2014/08/14 20:42:03]

nit: = 0

[Mike Lerman, 2014/08/14 20:58:30]

Done.

+    // User selects back from within the Not You? bubble.
+    PROFILE_AVATAR_MENU_NOT_YOU_BACK,
+    // User adds a person from within the Not You? bubble.
+    PROFILE_AVATAR_MENU_NOT_YOU_ADD_PERSON,
+    // User chooses to disconnect (sign out) from within the Not You? bubble.
+    PROFILE_AVATAR_MENU_NOT_YOU_DISCONNECT,
+    NUM_PROFILE_AVATAR_MENU_NOT_YOU_METRICS,
+  };
+
   static void UpdateReportedProfilesStatistics(ProfileManager* manager);
   // Count and return summary information about the profiles currently in the
   // |manager|. This information is returned in the output variable |counts|.
   static bool CountProfileInformation(ProfileManager* manager,
                                       ProfileCounts* counts);
 
   static void LogNumberOfProfiles(ProfileManager* manager);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileDeleteUser(ProfileDelete metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileAuthResult(ProfileAuth metric);
   static void LogProfileDesktopMenu(ProfileDesktopMenu metric,
                                     signin::GAIAServiceType gaia_service);
   static void LogProfileDelete(bool profile_was_signed_in);
+  static void LogProfileDesktopSignin(ProfileDesktopSignin metric);
+  static void LogProfileNewAvatarMenuUpgrade(
+      ProfileNewAvatarMenuUpgrade metric);
+  static void LogProfileNewAvatarMenuNotYou(ProfileNewAvatarMenuNotYou metric);
 
 #if defined(OS_ANDROID)
   static void LogProfileAndroidAccountManagementMenu(
       ProfileAndroidAccountManagementMenu metric,
       signin::GAIAServiceType gaia_service);
 #endif  // defined(OS_ANDROID)
 
   // These functions should only be called on the UI thread because they hook
   // into g_browser_process through a helper function.
   static void LogProfileLaunch(Profile* profile);
   static void LogProfileSyncSignIn(const base::FilePath& profile_path);
   static void LogProfileUpdate(const base::FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_