Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 470623010: [turbofan] Get rid of DefineAsDoubleRegister() and friends. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Get rid of DefineAsDoubleRegister() and friends. TEST=compiler-unittests,cctest,mjsunit R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -150 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 10 chunks +19 lines, -29 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 9 chunks +18 lines, -30 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 7 chunks +24 lines, -36 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 4 chunks +2 lines, -20 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 8 chunks +21 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
bmeurer@chromium.org changed reviewers: + svenpanne@chromium.org
6 years, 3 months ago (2014-08-26 07:42:22 UTC) #1
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-08-26 07:42:23 UTC) #2
Benedikt Meurer
Depends on https://codereview.chromium.org/500343002
6 years, 3 months ago (2014-08-26 07:55:18 UTC) #3
Sven Panne
lgtm
6 years, 3 months ago (2014-08-26 08:28:24 UTC) #4
Benedikt Meurer
6 years, 3 months ago (2014-08-26 08:30:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 23387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698