src/compiler/instruction-selector.cc - Issue 470593002: Unify MachineType and RepType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction-selector.cc

Issue 470593002: Unify MachineType and RepType. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Forgot a RepresentationOf() in arm64. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/instruction-selector.cc

diff --git a/src/compiler/instruction-selector.cc b/src/compiler/instruction-selector.cc

index 541e0452fa943273eb152769329863d4257ce614..90e7385230ee0487cf0b50ce69bb989ccc71533d 100644

--- a/src/compiler/instruction-selector.cc

+++ b/src/compiler/instruction-selector.cc

@@ -232,8 +232,8 @@ void InstructionSelector::MarkAsReference(Node* node) {

void InstructionSelector::MarkAsRepresentation(MachineType rep, Node* node) {

DCHECK_NOT_NULL(node);

- if (rep == kMachineFloat64) MarkAsDouble(node);

- if (rep == kMachineTagged) MarkAsReference(node);

+ if (RepresentationOf(rep) == rFloat64) MarkAsDouble(node);

+ if (RepresentationOf(rep) == rTagged) MarkAsReference(node);

}