src/compiler/instruction-selector-impl.h - Issue 470593002: Unify MachineType and RepType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction-selector-impl.h

Issue 470593002: Unify MachineType and RepType. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Forgot a RepresentationOf() in arm64. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/instruction-selector-impl.h

diff --git a/src/compiler/instruction-selector-impl.h b/src/compiler/instruction-selector-impl.h

index ac446b38ed8517bec29ff735c75fe3699f14f8f7..925c9541d36ab61254616b77be57f4d82d0e5bcd 100644

--- a/src/compiler/instruction-selector-impl.h

+++ b/src/compiler/instruction-selector-impl.h

@@ -201,7 +201,7 @@ class OperandGenerator {

return new (zone()) UnallocatedOperand(UnallocatedOperand::FIXED_SLOT,

location.location_);

}

- if (location.rep_ == kMachineFloat64) {

+ if ((location.rep_ & rMask) == rFloat64) {

Michael Starzinger 2014/08/13 15:40:05 nit: Can we use RepresentationOf here?

titzer 2014/08/13 16:12:58 Done.

return new (zone()) UnallocatedOperand(

UnallocatedOperand::FIXED_DOUBLE_REGISTER, location.location_);

}