Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470553002: DevTools: move TracingModel.js into the sdk module. (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: move TracingModel.js into the sdk module. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180174

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -693 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/devtools/front_end/sdk/TracingModel.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
D Source/devtools/front_end/timeline/TracingModel.js View 1 chunk +0 lines, -672 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 5 chunks +16 lines, -16 lines 0 comments Download
M Source/devtools/front_end/timeline/_module.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
pfeldman
6 years, 4 months ago (2014-08-13 09:57:29 UTC) #1
yurys
https://codereview.chromium.org/470553002/diff/1/Source/devtools/front_end/sdk/TracingModel.js File Source/devtools/front_end/sdk/TracingModel.js (right): https://codereview.chromium.org/470553002/diff/1/Source/devtools/front_end/sdk/TracingModel.js#newcode328 Source/devtools/front_end/sdk/TracingModel.js:328: this.dataArg = payload.args["data"]; Please revert this.
6 years, 4 months ago (2014-08-13 10:00:32 UTC) #2
pfeldman
https://codereview.chromium.org/470553002/diff/1/Source/devtools/front_end/sdk/TracingModel.js File Source/devtools/front_end/sdk/TracingModel.js (right): https://codereview.chromium.org/470553002/diff/1/Source/devtools/front_end/sdk/TracingModel.js#newcode328 Source/devtools/front_end/sdk/TracingModel.js:328: this.dataArg = payload.args["data"]; On 2014/08/13 10:00:32, yurys wrote: > ...
6 years, 4 months ago (2014-08-13 11:26:12 UTC) #3
yurys
lgtm
6 years, 4 months ago (2014-08-13 11:54:19 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-13 12:49:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/470553002/20001
6 years, 4 months ago (2014-08-13 12:49:58 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 13:53:34 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:23:27 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180174

Powered by Google App Engine
This is Rietveld 408576698