Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineModel.js

Issue 470553002: DevTools: move TracingModel.js into the sdk module. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments addressed. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TracingModel.js ('k') | Source/devtools/front_end/timeline/_module.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TracingTimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TracingTimelineModel.js b/Source/devtools/front_end/timeline/TracingTimelineModel.js
index dc5c411333ae6b44c981c055bc47641709e5e004..369b2c0ee2cf4d21f791212f469642bd6f82bca9 100644
--- a/Source/devtools/front_end/timeline/TracingTimelineModel.js
+++ b/Source/devtools/front_end/timeline/TracingTimelineModel.js
@@ -434,45 +434,45 @@ WebInspector.TracingTimelineModel.prototype = {
switch (event.name) {
case recordTypes.CallStack:
var lastMainThreadEvent = this.mainThreadEvents().peekLast();
- if (lastMainThreadEvent && event.args.stack && event.args.stack.length)
- lastMainThreadEvent.stackTrace = event.args.stack;
+ if (lastMainThreadEvent && event.args["stack"] && event.args["stack"].length)
+ lastMainThreadEvent.stackTrace = event.args["stack"];
break;
case recordTypes.ResourceSendRequest:
- this._sendRequestEvents[event.args.data["requestId"]] = event;
- event.imageURL = event.args.data["url"];
+ this._sendRequestEvents[event.args["data"]["requestId"]] = event;
+ event.imageURL = event.args["data"]["url"];
break;
case recordTypes.ResourceReceiveResponse:
case recordTypes.ResourceReceivedData:
case recordTypes.ResourceFinish:
- event.initiator = this._sendRequestEvents[event.args.data["requestId"]];
+ event.initiator = this._sendRequestEvents[event.args["data"]["requestId"]];
if (event.initiator)
event.imageURL = event.initiator.imageURL;
break;
case recordTypes.TimerInstall:
- this._timerEvents[event.args.data["timerId"]] = event;
+ this._timerEvents[event.args["data"]["timerId"]] = event;
break;
case recordTypes.TimerFire:
- event.initiator = this._timerEvents[event.args.data["timerId"]];
+ event.initiator = this._timerEvents[event.args["data"]["timerId"]];
break;
case recordTypes.RequestAnimationFrame:
- this._requestAnimationFrameEvents[event.args.data["id"]] = event;
+ this._requestAnimationFrameEvents[event.args["data"]["id"]] = event;
break;
case recordTypes.FireAnimationFrame:
- event.initiator = this._requestAnimationFrameEvents[event.args.data["id"]];
+ event.initiator = this._requestAnimationFrameEvents[event.args["data"]["id"]];
break;
case recordTypes.ScheduleStyleRecalculation:
- this._lastScheduleStyleRecalculation[event.args.frame] = event;
+ this._lastScheduleStyleRecalculation[event.args["frame"]] = event;
break;
case recordTypes.RecalculateStyles:
- event.initiator = this._lastScheduleStyleRecalculation[event.args.frame];
+ event.initiator = this._lastScheduleStyleRecalculation[event.args["frame"]];
this._lastRecalculateStylesEvent = event;
break;
@@ -480,7 +480,7 @@ WebInspector.TracingTimelineModel.prototype = {
// Consider style recalculation as a reason for layout invalidation,
// but only if we had no earlier layout invalidation records.
var layoutInitator = event;
- var frameId = event.args.frame;
+ var frameId = event.args["frame"];
if (!this._layoutInvalidate[frameId] && this._lastRecalculateStylesEvent && this._lastRecalculateStylesEvent.endTime > event.startTime)
layoutInitator = this._lastRecalculateStylesEvent.initiator;
this._layoutInvalidate[frameId] = layoutInitator;
@@ -497,13 +497,13 @@ WebInspector.TracingTimelineModel.prototype = {
break;
case recordTypes.WebSocketCreate:
- this._webSocketCreateEvents[event.args.data["identifier"]] = event;
+ this._webSocketCreateEvents[event.args["data"]["identifier"]] = event;
break;
case recordTypes.WebSocketSendHandshakeRequest:
case recordTypes.WebSocketReceiveHandshakeResponse:
case recordTypes.WebSocketDestroy:
- event.initiator = this._webSocketCreateEvents[event.args.data["identifier"]];
+ event.initiator = this._webSocketCreateEvents[event.args["data"]["identifier"]];
break;
case recordTypes.EvaluateScript:
@@ -764,7 +764,7 @@ WebInspector.TracingTimelineModel.TraceEventRecord.prototype = {
*/
data: function()
{
- return this._event.args.data;
+ return this._event.args["data"];
},
/**
@@ -788,7 +788,7 @@ WebInspector.TracingTimelineModel.TraceEventRecord.prototype = {
case WebInspector.TracingTimelineModel.RecordType.Layout:
return this._event.args["beginData"]["frameId"];
default:
- var data = this._event.args.data;
+ var data = this._event.args["data"];
return (data && data["frame"]) || "";
}
},
« no previous file with comments | « Source/devtools/front_end/timeline/TracingModel.js ('k') | Source/devtools/front_end/timeline/_module.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698