Move startup_helper_win.cc to separate target for incremental build

Move startup_helper_win.cc to separate target for incremental build

Currently, the .cc is included in multiple targets. In incremental builds this results in errors like:

[609->8104/8713 ~0] LINK_EMBED unit_tests.exe
FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True unit_tests.exe "d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:unit_tests.exe @unit_tests.exe.rsp" 1 mt.exe rc.exe "obj\chrome\unit_tests.unit_tests.exe.intermediate.manifest" obj\chrome\unit_tests.unit_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::InitializeSandboxInfo(struct sandbox::SandboxInterfaceInfo *)" (?InitializeSandboxInfo@content@@YAXPAUSandboxInterfaceInfo@sandbox@@@Z) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::InvalidParameter(wchar_t const *,wchar_t const *,wchar_t const *,unsigned int,unsigned int)" (?InvalidParameter@?A0xc496daa2@@YAXPB_W00II@Z) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::PureCall(void)" (?PureCall@?A0xc496daa2@@YAXXZ) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::RegisterInvalidParamHandler(void)" (?RegisterInvalidParamHandler@content@@YAXXZ) already defined in test_support_content.startup_helper_win.obj
content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::SetupCRT(class base::CommandLine const &)" (?SetupCRT@content@@YAXABVCommandLine@base@@@Z) already defined in test_support_content.startup_helper_win.obj
unit_tests.exe : fatal error LNK1169: one or more multiply defined symbols found

when incremental_chrome_dll=1 used in Release build.

By putting the .cc in a static_library target and depending on it as necessary, rather than including the .cc into multiple places, this is avoided.

R=jam@chromium.org
TBR=sky@chromium.org
BUG=404809
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291256

[jam, 2014-08-19 19:49:44]

lgtm

[scottmg, 2014-08-19 20:46:05]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-19 20:47:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/470523005/80001

[commit-bot: I haz the power, 2014-08-19 22:15:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-19 22:37:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 22:37:39]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[scottmg, 2014-08-20 16:53:47]

Hm, this is a bit messy because of the shared/static difference in how the
content libs are set up. I think I'll try removing it from content_app_both
instead.

[jam, 2014-08-20 23:28:43]

On 2014/08/20 16:53:47, scottmg wrote:
> Hm, this is a bit messy because of the shared/static difference in how the
> content libs are set up. I think I'll try removing it from content_app_both
> instead.

btw this file is special, it needs to be linked directly into chrome.exe for the
sandbox to work

[scottmg, 2014-08-20 23:29:55]

On 2014/08/20 23:28:43, jam wrote:
> On 2014/08/20 16:53:47, scottmg wrote:
> > Hm, this is a bit messy because of the shared/static difference in how the
> > content libs are set up. I think I'll try removing it from content_app_both
> > instead.
> 
> btw this file is special, it needs to be linked directly into chrome.exe for
the
> sandbox to work

You mean not a .lib? Hrm. How do I know if I broke it?

[jam, 2014-08-21 17:23:59]

On 2014/08/20 23:29:55, scottmg wrote:
> On 2014/08/20 23:28:43, jam wrote:
> > On 2014/08/20 16:53:47, scottmg wrote:
> > > Hm, this is a bit messy because of the shared/static difference in how the
> > > content libs are set up. I think I'll try removing it from
content_app_both
> > > instead.
> > 
> > btw this file is special, it needs to be linked directly into chrome.exe for
> the
> > sandbox to work
> 
> You mean not a .lib? Hrm. How do I know if I broke it?

.lib is fine. what i mean is that the file can't be linked to chrome.dll, and
use CONTENT_EXPORT for chrome.exe to call that method.

you'll know because chrome won't work :)

[scottmg, 2014-08-21 17:56:10]

On 2014/08/21 17:23:59, jam wrote:
> On 2014/08/20 23:29:55, scottmg wrote:
> > On 2014/08/20 23:28:43, jam wrote:
> > > On 2014/08/20 16:53:47, scottmg wrote:
> > > > Hm, this is a bit messy because of the shared/static difference in how
the
> > > > content libs are set up. I think I'll try removing it from
> content_app_both
> > > > instead.
> > > 
> > > btw this file is special, it needs to be linked directly into chrome.exe
for
> > the
> > > sandbox to work
> > 
> > You mean not a .lib? Hrm. How do I know if I broke it?
> 
> .lib is fine. what i mean is that the file can't be linked to chrome.dll, and
> use CONTENT_EXPORT for chrome.exe to call that method.
> 
> you'll know because chrome won't work :)

OK, this should be safe then I think. Thanks.

[scottmg, 2014-08-21 17:56:28]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-21 17:59:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/470523005/240001

[scottmg, 2014-08-21 18:11:06]

tbr sky for minor ui/ gyp changes

[scottmg, 2014-08-21 18:11:13]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2014-08-21 18:11:15]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-21 18:13:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/470523005/240001

[jam, 2014-08-21 21:22:45]

still lgtm

[commit-bot: I haz the power, 2014-08-22 00:06:26]

Committed patchset #7 (240001) as 291256