Fix segfault when getting network details.

Fix segfault when getting network details.

Segfault occurs in internet_options_handler.cc when accessing a
non-existent policy. This was introduced in https://crrev.com/427903004.

Please note: http://imgur.com/sD3vz0W.jpg

BUG=403111
R=pneubeck@chromium.org
TBR=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289201

[michaelpg, 2014-08-13 01:06:06]

PTAL.

[pneubeck (no reviews), 2014-08-13 02:37:14]

lgtm
note, that only Steven Bennetts and I worked on this code recently / the most,
but I'm not in the OWNERS file. You might have to TBR Steven.

https://codereview.chromium.org/470433002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/470433002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1379: onc
&& onc::IsRecommendedValue(onc, onc_path_to_auto_connect);
optional nit:
strictly, this 'onc' condition shouldn't be necessary.
to help the reader, a DCHECK_EQ(onc == NULL, onc_source ==
::onc::ONC_SOURCE_NONE) could be added instead.

[pneubeck (no reviews), 2014-08-13 02:40:20]

and thanks for fixing this, this night and most of tomorrow I'm on the airplan

[michaelpg, 2014-08-13 02:58:26]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2014-08-13 02:59:03]

https://codereview.chromium.org/470433002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/470433002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1379: onc
&& onc::IsRecommendedValue(onc, onc_path_to_auto_connect);
On 2014/08/13 02:37:14, pneubeck wrote:
> optional nit:
> strictly, this 'onc' condition shouldn't be necessary.
> to help the reader, a DCHECK_EQ(onc == NULL, onc_source ==
> ::onc::ONC_SOURCE_NONE) could be added instead.

Done.

[commit-bot: I haz the power, 2014-08-13 03:00:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/470433002/40001

[commit-bot: I haz the power, 2014-08-13 04:13:04]

Change committed as 289201