Fix segfault when getting network details.

chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/internet_options_handler.h"
 
 #include <ctype.h>
 
 #include <map>
 #include <string>
@@ skipping 1358 matching lines @@
   if (!onc_path_to_auto_connect.empty()) {
     bool auto_connect = false;
     shill_properties.GetBooleanWithoutPathExpansion(
         shill::kAutoConnectProperty, &auto_connect);
 
     scoped_ptr<base::Value> auto_connect_value(
         new base::FundamentalValue(auto_connect));
     ::onc::ONCSource auto_connect_onc_source = onc_source;
     bool auto_connect_recommended =
         auto_connect_onc_source != ::onc::ONC_SOURCE_NONE &&
-        onc::IsRecommendedValue(onc, onc_path_to_auto_connect);
-    // |auto_connect_default_value| will contain either a recommended value
-    // if |auto_connect_recommended| is true, or an enforced value otherwise.
+        onc && onc::IsRecommendedValue(onc, onc_path_to_auto_connect);

[pneubeck (no reviews), 2014/08/13 02:37:14]

optional nit:
strictly, this 'onc' condition shouldn't be necessary.
to help the reader, a DCHECK_EQ(onc == NULL, onc_source ==
::onc::ONC_SOURCE_NONE) could be added instead.

[michaelpg, 2014/08/13 02:59:03]

Done.

+    // If a policy exists, |auto_connect_default_value| will contain either a
+    // recommended value (if |auto_connect_recommended| is true) or an enforced
+    // value (if |auto_connect_recommended| is false).
     const base::Value* auto_connect_default_value = NULL;
-    onc->Get(onc_path_to_auto_connect, &auto_connect_default_value);
+    if (onc)
+      onc->Get(onc_path_to_auto_connect, &auto_connect_default_value);
 
     // Autoconnect can be controlled by the GlobalNetworkConfiguration of the
     // ONC policy.
     if (auto_connect_onc_source == ::onc::ONC_SOURCE_NONE &&
         onc::PolicyAllowsOnlyPolicyNetworksToAutoconnect(
             network->IsPrivate())) {
       auto_connect_recommended = false;
       auto_connect_onc_source = network->IsPrivate()
                                     ? ::onc::ONC_SOURCE_USER_POLICY
                                     : ::onc::ONC_SOURCE_DEVICE_POLICY;
@@ skipping 202 matching lines @@
   dictionary->SetBoolean(
       kTagWimaxAvailable,
       handler->IsTechnologyAvailable(NetworkTypePattern::Wimax()));
   dictionary->SetBoolean(
       kTagWimaxEnabled,
       handler->IsTechnologyEnabled(NetworkTypePattern::Wimax()));
 }
 
 }  // namespace options
 }  // namespace chromeos