Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 470093002: DevTools: NetworkPanel: fix node hightlight and reveal on search. (Closed)

Created:
6 years, 4 months ago by eustas
Modified:
6 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: NetworkPanel: fix search. Problem: Nodes are not revealed and not highlighted. Search box constantly loose focus. Solution: Do not focus dataGrid on node reveal. Avoid refresh of all nodes on node reveal. Fix parameter type passed to revealer. Match and highlight same element. Reval node before highlight. Most probably regressed by: https://codereview.chromium.org/391083003 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180258

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 1 8 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eustas
6 years, 4 months ago (2014-08-14 10:05:11 UTC) #1
vsevik
lgtm, but please make issue title just a bit more informative. Also the description is ...
6 years, 4 months ago (2014-08-14 11:11:40 UTC) #2
vsevik
https://codereview.chromium.org/470093002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/470093002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode940 Source/devtools/front_end/network/NetworkPanel.js:940: switchViewMode: function(detailed) { { on the next line
6 years, 4 months ago (2014-08-14 11:12:44 UTC) #3
eustas
https://codereview.chromium.org/470093002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/470093002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode940 Source/devtools/front_end/network/NetworkPanel.js:940: switchViewMode: function(detailed) { On 2014/08/14 11:12:44, vsevik wrote: > ...
6 years, 4 months ago (2014-08-14 11:32:05 UTC) #4
eustas
On 2014/08/14 11:11:40, vsevik wrote: > lgtm, but please make issue title just a bit ...
6 years, 4 months ago (2014-08-14 11:33:32 UTC) #5
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-14 11:33:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/470093002/20001
6 years, 4 months ago (2014-08-14 11:34:06 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:30:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180258

Powered by Google App Engine
This is Rietveld 408576698