Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391083003: DevTools: remove Node.reveal() and RemoteOject.reveal() (Closed)

Created:
6 years, 5 months ago by caseq
Modified:
6 years, 5 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: remove Node.reveal() and RemoteOject.reveal() SDK objects should not be aware of UI-level concepts. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -28 lines) Patch
M Source/devtools/front_end/ScreencastView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 2 chunks +5 lines, -11 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
caseq
6 years, 5 months ago (2014-07-15 11:38:02 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-15 13:43:05 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 5 months ago (2014-07-15 13:43:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/391083003/1
6 years, 5 months ago (2014-07-15 13:44:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-15 14:47:52 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 17:13:14 UTC) #6
Message was sent while issue was closed. 
Change committed as 178186

Powered by Google App Engine
This is Rietveld 408576698