chrome/browser/ui/views/extensions/extension_message_bubble_view.cc - Issue 469973005: Add tests for the BrowserActionsContainer in overflow mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 469973005: Add tests for the BrowserActionsContainer in overflow mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter's Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

index 068efd33085d619ed820f0e58fc0b5ae106cfd35..d741779cffa7d82b45c9bee97c9d1a34de763f87 100644

--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

@@ -485,7 +485,7 @@ void ExtensionMessageBubbleFactory::ShowHighlightingBubble() {

stage_ = STAGE_COMPLETE;

views::View* reference_view = NULL;

- if (container_->num_browser_actions() > 0)

+ if (container_->num_browser_actions() > 0u)

reference_view = container_->GetBrowserActionViewAt(0);

if (reference_view && reference_view->visible())

anchor_view_ = reference_view;