Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 469973005: Add tests for the BrowserActionsContainer in overflow mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Peter's Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h" 10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 MaybeObserve(); 478 MaybeObserve();
479 else 479 else
480 ShowHighlightingBubble(); 480 ShowHighlightingBubble();
481 } 481 }
482 482
483 void ExtensionMessageBubbleFactory::ShowHighlightingBubble() { 483 void ExtensionMessageBubbleFactory::ShowHighlightingBubble() {
484 DCHECK_EQ(stage_, STAGE_HIGHLIGHTED); 484 DCHECK_EQ(stage_, STAGE_HIGHLIGHTED);
485 stage_ = STAGE_COMPLETE; 485 stage_ = STAGE_COMPLETE;
486 486
487 views::View* reference_view = NULL; 487 views::View* reference_view = NULL;
488 if (container_->num_browser_actions() > 0) 488 if (container_->num_browser_actions() > 0u)
489 reference_view = container_->GetBrowserActionViewAt(0); 489 reference_view = container_->GetBrowserActionViewAt(0);
490 if (reference_view && reference_view->visible()) 490 if (reference_view && reference_view->visible())
491 anchor_view_ = reference_view; 491 anchor_view_ = reference_view;
492 492
493 ExtensionMessageBubbleController* weak_controller = controller_.get(); 493 ExtensionMessageBubbleController* weak_controller = controller_.get();
494 ExtensionMessageBubbleView* bubble_delegate = 494 ExtensionMessageBubbleView* bubble_delegate =
495 new ExtensionMessageBubbleView( 495 new ExtensionMessageBubbleView(
496 anchor_view_, 496 anchor_view_,
497 views::BubbleBorder::TOP_RIGHT, 497 views::BubbleBorder::TOP_RIGHT,
498 scoped_ptr<ExtensionMessageBubbleController>( 498 scoped_ptr<ExtensionMessageBubbleController>(
499 controller_.release())); 499 controller_.release()));
500 views::BubbleDelegateView::CreateBubble(bubble_delegate); 500 views::BubbleDelegateView::CreateBubble(bubble_delegate);
501 weak_controller->Show(bubble_delegate); 501 weak_controller->Show(bubble_delegate);
502 502
503 Finish(); 503 Finish();
504 } 504 }
505 505
506 void ExtensionMessageBubbleFactory::Finish() { 506 void ExtensionMessageBubbleFactory::Finish() {
507 MaybeStopObserving(); 507 MaybeStopObserving();
508 controller_.reset(); 508 controller_.reset();
509 anchor_view_ = NULL; 509 anchor_view_ = NULL;
510 container_ = NULL; 510 container_ = NULL;
511 } 511 }
512 512
513 } // namespace extensions 513 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698