Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 469803004: Revert 289115 "Revert 288464 "[Sync] Cleanup datatype configurat..." (Closed)

Created:
6 years, 4 months ago by oshima
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 289115 "Revert 288464 "[Sync] Cleanup datatype configurat..." > Revert 288464 "[Sync] Cleanup datatype configuration error handl..." > > Reason for revert: see crbug.com/403098 > > > [Sync] Cleanup datatype configuration error handling. > > > > The FailedDataTypeHandler is now informed immediately of failures, including > > datatype errors, and is therefore authoritative source for all errors. As such, > > partial success is no longer tracked and the various ModelTypeSets for error > > types in configure results are removed. > > > > BUG=368834, 403098 > > > > Review URL: https://codereview.chromium.org/420633002 > > TBR=zea@chromium.org > > Review URL: https://codereview.chromium.org/468643002 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -495 lines) Patch
M trunk/src/chrome/browser/sync/backend_migrator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/backend_migrator_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc View 7 chunks +26 lines, -17 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_controller.h View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_controller_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/sync_driver/data_type_manager.h View 2 chunks +2 lines, -21 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_manager.cc View 2 chunks +4 lines, -20 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_manager_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_manager_impl.cc View 8 chunks +40 lines, -72 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_manager_impl_unittest.cc View 6 chunks +39 lines, -5 lines 0 comments Download
M trunk/src/components/sync_driver/failed_data_types_handler.h View 1 chunk +8 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/failed_data_types_handler.cc View 4 chunks +21 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/fake_data_type_controller.h View 2 chunks +8 lines, -13 lines 0 comments Download
M trunk/src/components/sync_driver/fake_data_type_controller.cc View 7 chunks +27 lines, -9 lines 0 comments Download
M trunk/src/components/sync_driver/model_association_manager.h View 4 chunks +4 lines, -19 lines 0 comments Download
M trunk/src/components/sync_driver/model_association_manager.cc View 12 chunks +62 lines, -109 lines 0 comments Download
M trunk/src/components/sync_driver/model_association_manager_unittest.cc View 11 chunks +53 lines, -100 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller.cc View 9 chunks +22 lines, -19 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller_mock.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M trunk/src/components/sync_driver/ui_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/ui_data_type_controller.cc View 6 chunks +17 lines, -11 lines 0 comments Download
M trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/sync/api/sync_error.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
6 years, 4 months ago (2014-08-13 19:58:17 UTC) #1
oshima
6 years, 4 months ago (2014-08-13 19:58:27 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r289354.

Powered by Google App Engine
This is Rietveld 408576698