Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 469783002: Require V8 to be explicitly initialized before an Isolate is created (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Require V8 to be explicitly initialized before an Isolate is created We also initialize the Isolate on creation. This should allow for getting rid of the last remaining default isolate traces. Also, it'll speed up several isolate related operations that no longer require locks. Embedders that relied on v8::Isolate to return an uninitialized Isolate (so they can set ResourceConstraints for example, or set flags that modify the way the isolate is created) should either do the setup before creating the isolate, or use the recently added CreateParams to pass e.g. ResourceConstraints. BUG=none LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24052

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1136 lines, -1127 lines) Patch
M include/v8.h View 1 5 chunks +19 lines, -11 lines 0 comments Download
M samples/lineprocessor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M samples/process.cc View 1 chunk +1 line, -0 lines 0 comments Download
M samples/shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 35 chunks +12 lines, -62 lines 0 comments Download
M src/base/utils/random-number-generator.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/base/utils/random-number-generator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/d8.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 2 3 5 chunks +5 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 6 chunks +17 lines, -18 lines 0 comments Download
M src/mksnapshot.cc View 1 3 chunks +10 lines, -7 lines 0 comments Download
M src/snapshot.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/snapshot-common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/snapshot-external.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/v8.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/cctest.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/cctest.cc View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 2 chunks +7 lines, -15 lines 0 comments Download
M test/cctest/test-ast.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-dataflow.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 10 chunks +80 lines, -52 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 14 chunks +349 lines, -273 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 chunks +176 lines, -155 lines 0 comments Download
M test/cctest/test-liveedit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 6 chunks +145 lines, -130 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 23 chunks +0 lines, -24 lines 0 comments Download
M test/cctest/test-macro-assembler-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-random-number-generator.cc View 1 2 1 chunk +4 lines, -16 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 17 chunks +0 lines, -18 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 9 chunks +280 lines, -287 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 5 chunks +0 lines, -10 lines 0 comments Download
M tools/lexer-shell.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/parser-shell.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jochen (gone - plz use gerrit)
getting closer to passing all tests... still need to fix snapshot=off mode
6 years, 3 months ago (2014-09-17 11:57:01 UTC) #2
jochen (gone - plz use gerrit)
.... and we're there. please review :)
6 years, 3 months ago (2014-09-18 12:38:33 UTC) #3
Sven Panne
LGTM. Slowly things begin to look sane... :-)
6 years, 3 months ago (2014-09-18 13:21:41 UTC) #4
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-18 21:08:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 24052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698