src/bootstrapper.cc - Issue 469783002: Require V8 to be explicitly initialized before an Isolate is created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 469783002: Require V8 to be explicitly initialized before an Isolate is created (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 855080c34869ea5b69d800df9f8f34ec626733aa..e6f8a133123995a8191a3832a3c99cd6881e332d 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -2594,9 +2594,6 @@ Genesis::Genesis(Isolate* isolate,

active_(isolate->bootstrapper()) {

NoTrackDoubleFieldsForSerializerScope disable_scope(isolate);

result_ = Handle<Context>::null();

- // If V8 cannot be initialized, just return.

- if (!V8::Initialize(NULL)) return;

// Before creating the roots we must save the context and restore it

// on all function exits.

SaveContext saved_context(isolate);

« no previous file with comments | « src/base/utils/random-number-generator.cc ('k') | src/d8.cc » ('j') | no next file with comments »