Issue 469743002: [turbofan] Refactor the InstructionSelector tests.

Issue 469743002: [turbofan] Refactor the InstructionSelector tests. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Refactor the InstructionSelector tests. Also fix some issues and improve test coverage. TEST=compiler-unittests BUG=v8:3489 LOG=y R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23111

Patch Set 1 #

Patch Set 2 : ARM and IA32 #

Patch Set 3 : REBASE #

Total comments: 2

Patch Set 4 : ARM64 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2069 lines, -2163 lines)			Patch
M	src/compiler/arm/instruction-selector-arm.cc	View		1 chunk	+16 lines, -5 lines	0 comments	Download
M	src/compiler/machine-node-factory.h	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 2 3	4 chunks	+0 lines, -4 lines	0 comments	Download
D	test/cctest/compiler/test-instruction-selector.cc	View	1	1 chunk	+0 lines, -22 lines	0 comments	Download
M	test/cctest/compiler/test-instruction-selector-arm.cc	View	1	1 chunk	+0 lines, -1863 lines	0 comments	Download
D	test/cctest/compiler/test-instruction-selector-arm64.cc	View	1 2 3	1 chunk	+0 lines, -157 lines	0 comments	Download
D	test/cctest/compiler/test-instruction-selector-ia32.cc	View	1	1 chunk	+0 lines, -66 lines	0 comments	Download
M	test/compiler-unittests/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/compiler-unittests/arm/instruction-selector-arm-unittest.cc	View	1	1 chunk	+1707 lines, -4 lines	0 comments	Download
A	test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc	View	1 2 3	1 chunk	+133 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/change-lowering-unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/compiler-unittests/compiler-unittests.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/compiler-unittests/compiler-unittests.gyp	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/compiler-unittests/ia32/instruction-selector-ia32-unittest.cc	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/instruction-selector-unittest.h	View		6 chunks	+37 lines, -1 line	0 comments	Download
M	test/compiler-unittests/instruction-selector-unittest.cc	View	1	4 chunks	+12 lines, -3 lines	0 comments	Download
M	testing/gtest.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	testing/gtest-support.h	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
D	testing/gtest-type-names.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc File src/compiler/arm/instruction-selector-arm.cc (right): https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc#newcode151 src/compiler/arm/instruction-selector-arm.cc:151: if (mshl.right().IsInt32Sub()) { I am a bit confused ...

6 years, 4 months ago (2014-08-14 05:34:55 UTC) #3

Benedikt Meurer

https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc File src/compiler/arm/instruction-selector-arm.cc (right): https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc#newcode151 src/compiler/arm/instruction-selector-arm.cc:151: if (mshl.right().IsInt32Sub()) { On 2014/08/14 05:34:55, jarin wrote: > ...

6 years, 4 months ago (2014-08-14 06:22:46 UTC) #4

Benedikt Meurer

6 years, 4 months ago (2014-08-14 06:34:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as 23111 (presubmit successful).

Expand Messages | Collapse Messages