Issue 469693005: Fix checkperms after the changes from http://crrev.com/289225.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469693005: Fix checkperms after the changes from http://crrev.com/289225. (Closed)

Created:
6 years, 4 months ago by Joao da Silva

Modified:
6 years, 4 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix checkperms after the changes from http://crrev.com/289225. TBR=tonyg@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289249

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	A	tools/telemetry/telemetry/page/record_wpr.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Committed patchset #1 manually as 289249 (presubmit successful).

6 years, 4 months ago (2014-08-13 10:08:02 UTC) #1

Joao da Silva

This change removes the executable flag to fix: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/8906/steps/checkperms/logs/stdio Problem started in: https://codereview.chromium.org/465213002

6 years, 4 months ago (2014-08-13 10:08:34 UTC) #2

tonyg

Thanks for the quick fix! I'm a little puzzled as the props change show up ...

6 years, 4 months ago (2014-08-13 14:23:39 UTC) #3

Joao da Silva

6 years, 4 months ago (2014-08-13 14:25:11 UTC) #4

Message was sent while issue was closed.

On 2014/08/13 14:23:39, tonyg wrote:
> Thanks for the quick fix!
> 
> I'm a little puzzled as the props change show up in my patch here and the CQ
was
> happy:
> https://codereview.chromium.org/465213002/patch/20001/30001
> 
> Perhaps this has to be done from SVN instead of git? Or perhaps the CQ doesn't
> respect it?

FWIW git showed the file as modified in "git status" after changing the +x flag.
So I'm guessing it's the CQ, but I'm really not familiar with it.

Expand Messages | Collapse Messages