Issue 465213002: [Telemetry] Remove arbitrary sleep in record_wpr.

Issue 465213002: [Telemetry] Remove arbitrary sleep in record_wpr. (Closed)

Created:
6 years, 4 months ago by tonyg

Modified:
6 years, 4 months ago

Reviewers:
ariblue, dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Remove arbitrary sleep in record_wpr. This fixes an old TODO, makes recording more robust and improves the cycle time of the record_wpr unittests from about 33s -> 26s on my MBP. BUG=388256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289225

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix import order #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	tools/telemetry/telemetry/page/record_wpr.py	View	1	2 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dtu

https://codereview.chromium.org/465213002/diff/1/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (left): https://codereview.chromium.org/465213002/diff/1/tools/telemetry/telemetry/page/record_wpr.py#oldcode1 tools/telemetry/telemetry/page/record_wpr.py:1: #!/usr/bin/env python Might have to disable executable bit? https://codereview.chromium.org/465213002/diff/1/tools/telemetry/telemetry/page/record_wpr.py ...

6 years, 4 months ago (2014-08-13 05:47:08 UTC) #2

tonyg

6 years, 4 months ago (2014-08-13 05:51:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/465213002/20001

6 years, 4 months ago (2014-08-13 06:10:44 UTC) #6

Message was sent while issue was closed.

Change committed as 289225

Expand Messages | Collapse Messages