Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 469623002: Revert of Make landmines work on local builds too (Closed)

Created:
6 years, 4 months ago by iannucci
Modified:
6 years, 4 months ago
Reviewers:
scottmg, matthewyuan
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Make landmines work on local builds too (patchset #3 of https://codereview.chromium.org/457003004/) Reason for revert: Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build): Traceback (most recent call last): File "src/build/landmines.py", line 132, in <module> sys.exit(main()) File "src/build/landmines.py", line 119, in main gyp_environment.SetEnvironment() File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs() File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs with open(json_data_file, 'r') as tempf: IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json' Original issue's description: > Make landmines work on local builds too > > Moves (some of) gyp environment setup out of gyp_chromium into separate > module, and shares that between gyp_chromium and landmines.py. > > landmines.py is added as the first entry in DEPS hooks so that it can > clobber the entire build directory before running other hooks that > extract/generate into the build dir. > > R=iannucci@chromium.org > BUG=400011 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099 TBR=scottmg@chromium.org NOTREECHECKS=true NOTRY=true BUG=400011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -79 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
M build/get_landmines.py View 3 chunks +13 lines, -2 lines 0 comments Download
M build/gyp_chromium View 6 chunks +29 lines, -4 lines 0 comments Download
D build/gyp_environment.py View 1 chunk +0 lines, -33 lines 0 comments Download
M build/landmines.py View 6 chunks +31 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
Created Revert of Make landmines work on local builds too
6 years, 4 months ago (2014-08-13 01:59:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/469623002/1
6 years, 4 months ago (2014-08-13 02:02:47 UTC) #2
commit-bot: I haz the power
Change committed as 289158
6 years, 4 months ago (2014-08-13 02:07:37 UTC) #3
scottmg
On 2014/08/13 02:07:37, I haz the power (commit-bot) wrote: > Change committed as 289158 Bah. ...
6 years, 4 months ago (2014-08-13 02:44:03 UTC) #4
scottmg
6 years, 4 months ago (2014-08-13 02:44:09 UTC) #5
Message was sent while issue was closed.
On 2014/08/13 02:44:03, scottmg wrote:
> On 2014/08/13 02:07:37, I haz the power (commit-bot) wrote:
> > Change committed as 289158
> 
> Bah. Thanks.

er, lgtm.

Powered by Google App Engine
This is Rietveld 408576698