Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4980)

Unified Diff: build/get_landmines.py

Issue 469623002: Revert of Make landmines work on local builds too (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | build/gyp_chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/get_landmines.py
diff --git a/build/get_landmines.py b/build/get_landmines.py
index da676451bf5ecd986c98f2b573df03e7eb46ce0e..ee7f76af8f5017e990159a225bcc9e1fc75415d9 100755
--- a/build/get_landmines.py
+++ b/build/get_landmines.py
@@ -8,6 +8,7 @@
(or a list of 'landmines').
"""
+import optparse
import sys
import landmine_utils
@@ -20,9 +21,10 @@
platform = landmine_utils.platform
-def print_landmines():
+def print_landmines(target):
"""
ALL LANDMINES ARE EMITTED FROM HERE.
+ target can be one of {'Release', 'Debug', 'Debug_x64', 'Release_x64'}.
"""
if (distributor() == 'goma' and platform() == 'win32' and
builder() == 'ninja'):
@@ -59,7 +61,16 @@
def main():
- print_landmines()
+ parser = optparse.OptionParser()
+ parser.add_option('-t', '--target',
+ help=='Target for which the landmines have to be emitted')
+
+ options, args = parser.parse_args()
+
+ if args:
+ parser.error('Unknown arguments %s' % args)
+
+ print_landmines(options.target)
return 0
« no previous file with comments | « DEPS ('k') | build/gyp_chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698