Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 469293002: Revert 289526 "Fix Mac sandbox meta data access" (Closed)

Created:
6 years, 4 months ago by bartfab (slow)
Modified:
6 years, 4 months ago
Reviewers:
Jiang Jiang
CC:
chromium-reviews, Nico
Visibility:
Public.

Description

Revert 289526 "Fix Mac sandbox meta data access" Speculative revert as a lot of Mac bots broke when this landed: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/54365 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/43947 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/52314 > Fix Mac sandbox meta data access > > Sandbox::AllowMetadataForPath() currently allow all metadata access due to > https://codereview.chromium.org/10539009/ made the for loop comparison > in Sandbox::AllowMetadataForPath() always false, when we actually only > want to allow access to the path and all its parent path until root. > > Turn the for loop to a do/while loop instead as it's a better fit, also > add a test case for Sandbox::AllowMetadataForPath(). > > It should only affect component builds on OS X 10.6 and utility process > as no other process is using this mechanism. > > Review URL: https://codereview.chromium.org/472513002 TBR=jiangj@opera.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M trunk/src/content/common/sandbox_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/common/sandbox_mac.mm View 1 chunk +4 lines, -6 lines 0 comments Download
M trunk/src/content/common/sandbox_mac_diraccess_unittest.mm View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
6 years, 4 months ago (2014-08-14 13:05:14 UTC) #1
bartfab (slow)
Committed patchset #1 manually as r289541 (tree was closed).
6 years, 4 months ago (2014-08-14 13:05:34 UTC) #2
Jiang Jiang
On 2014/08/14 13:05:34, bartfab wrote: > Committed patchset #1 manually as r289541 (tree was closed). ...
6 years, 4 months ago (2014-08-14 13:18:04 UTC) #3
bartfab (slow)
On 2014/08/14 13:18:04, Jiang wrote: > On 2014/08/14 13:05:34, bartfab wrote: > > Committed patchset ...
6 years, 4 months ago (2014-08-14 13:24:56 UTC) #4
Jiang Jiang
On 2014/08/14 13:24:56, bartfab wrote: > On 2014/08/14 13:18:04, Jiang wrote: > > On 2014/08/14 ...
6 years, 4 months ago (2014-08-14 15:41:47 UTC) #5
Jiang Jiang
6 years, 4 months ago (2014-08-14 15:42:15 UTC) #6
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698