Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 472513002: Fix Mac sandbox meta data access (Closed)

Created:
6 years, 4 months ago by Jiang Jiang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Mac sandbox meta data access Sandbox::AllowMetadataForPath() currently allow all metadata access due to https://codereview.chromium.org/10539009/ made the for loop comparison in Sandbox::AllowMetadataForPath() always false, when we actually only want to allow access to the path and all its parent path until root. Turn the for loop to a do/while loop instead as it's a better fit, also add a test case for Sandbox::AllowMetadataForPath(). It should only affect component builds on OS X 10.6 and utility process as no other process is using this mechanism. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M content/common/sandbox_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +6 lines, -4 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Jiang Jiang
6 years, 4 months ago (2014-08-13 16:00:05 UTC) #1
Nico
lgtm, thanks!
6 years, 4 months ago (2014-08-13 16:08:00 UTC) #2
Avi (use Gerrit)
owner drive-by lgtm
6 years, 4 months ago (2014-08-13 16:27:14 UTC) #3
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 4 months ago (2014-08-13 17:09:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/472513002/1
6 years, 4 months ago (2014-08-13 17:11:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 02:03:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 08:06:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5513)
6 years, 4 months ago (2014-08-14 08:06:38 UTC) #8
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 4 months ago (2014-08-14 08:27:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/472513002/1
6 years, 4 months ago (2014-08-14 08:29:10 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 11:25:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 289526

Powered by Google App Engine
This is Rietveld 408576698