Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 469213007: Start actually bounding some draw ops. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org, fmalita_google_do_not_use
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Start actually bounding some draw ops. This covers most of the common draws. BUG=skia: Committed: https://skia.googlesource.com/skia/+/62b67ae96e94fd22569b058a3bc4625b9f52ed56

Patch Set 1 #

Patch Set 2 : some text too #

Patch Set 3 : rebase #

Patch Set 4 : Fixed? #

Total comments: 2

Patch Set 5 : update test #

Patch Set 6 : Robert #

Patch Set 7 : ) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M src/core/SkRecordDraw.cpp View 1 2 3 4 5 6 1 chunk +82 lines, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
mtklein
6 years, 4 months ago (2014-08-18 17:13:08 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-18 17:13:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/469213007/60001
6 years, 4 months ago (2014-08-18 17:13:24 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-18 17:13:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-18 17:20:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 17:24:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/230)
6 years, 4 months ago (2014-08-18 17:24:05 UTC) #7
robertphillips
lgtm + 1 nit & 1 potential fix https://codereview.chromium.org/469213007/diff/60001/src/core/SkRecordDraw.cpp File src/core/SkRecordDraw.cpp (right): https://codereview.chromium.org/469213007/diff/60001/src/core/SkRecordDraw.cpp#newcode289 src/core/SkRecordDraw.cpp:289: SkRect ...
6 years, 4 months ago (2014-08-18 17:48:40 UTC) #8
mtklein
On 2014/08/18 17:48:40, robertphillips wrote: > lgtm + 1 nit & 1 potential fix > ...
6 years, 4 months ago (2014-08-18 18:01:41 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-18 18:02:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/469213007/120001
6 years, 4 months ago (2014-08-18 18:03:05 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 18:10:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #7 (120001) as 62b67ae96e94fd22569b058a3bc4625b9f52ed56

Powered by Google App Engine
This is Rietveld 408576698