Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/core/SkRecordDraw.cpp

Issue 469213007: Start actually bounding some draw ops. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: ) Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/RecordDrawTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkRecordDraw.h" 8 #include "SkRecordDraw.h"
9 #include "SkTSort.h" 9 #include "SkTSort.h"
10 10
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 fControlIndices.pop(); 231 fControlIndices.pop();
232 } 232 }
233 233
234 void updateSaveBounds(const SkIRect& bounds) { 234 void updateSaveBounds(const SkIRect& bounds) {
235 // If we're in a Save block, expand its bounds to cover these bounds too . 235 // If we're in a Save block, expand its bounds to cover these bounds too .
236 if (!fSaveStack.isEmpty()) { 236 if (!fSaveStack.isEmpty()) {
237 fSaveStack.top().bounds.join(bounds); 237 fSaveStack.top().bounds.join(bounds);
238 } 238 }
239 } 239 }
240 240
241 // TODO: Remove this default when done bounding all ops. 241 // TODO(mtklein): Remove this default when done bounding all ops.
242 template <typename T> SkIRect bounds(const T&) const { return fCurrentClipBo unds; } 242 template <typename T> SkIRect bounds(const T&) const { return fCurrentClipBo unds; }
243 SkIRect bounds(const Clear&) const { return SkIRect::MakeLargest(); } // Ig nores the clip 243 SkIRect bounds(const Clear&) const { return SkIRect::MakeLargest(); } // Ig nores the clip
244 SkIRect bounds(const NoOp&) const { return SkIRect::MakeEmpty(); } // No Ops don't draw. 244 SkIRect bounds(const NoOp&) const { return SkIRect::MakeEmpty(); } // No Ops don't draw.
245 245
246 SkIRect bounds(const DrawRect& op) const { return this->adjustAndMap(op.rect , &op.paint); }
247 SkIRect bounds(const DrawOval& op) const { return this->adjustAndMap(op.oval , &op.paint); }
248 SkIRect bounds(const DrawRRect& op) const {
249 return this->adjustAndMap(op.rrect.rect(), &op.paint);
250 }
251 SkIRect bounds(const DrawDRRect& op) const {
252 return this->adjustAndMap(op.outer.rect(), &op.paint);
253 }
254
255 SkIRect bounds(const DrawBitmapRectToRect& op) const {
256 return this->adjustAndMap(op.dst, op.paint);
257 }
258 SkIRect bounds(const DrawBitmapNine& op) const {
259 return this->adjustAndMap(op.dst, op.paint);
260 }
261 SkIRect bounds(const DrawBitmap& op) const {
262 const SkBitmap& bm = op.bitmap;
263 return this->adjustAndMap(SkRect::MakeXYWH(op.left, op.top, bm.width(), bm.height()),
264 op.paint);
265 }
266 SkIRect bounds(const DrawBitmapMatrix& op) const {
267 const SkBitmap& bm = op.bitmap;
268 SkRect dst = SkRect::MakeWH(bm.width(), bm.height());
269 op.matrix.mapRect(&dst);
270 return this->adjustAndMap(dst, op.paint);
271 }
272
273 SkIRect bounds(const DrawPath& op) const {
274 return op.path.isInverseFillType() ? fCurrentClipBounds
275 : this->adjustAndMap(op.path.getBound s(), &op.paint);
276 }
277 SkIRect bounds(const DrawPoints& op) const {
278 SkRect dst;
279 dst.set(op.pts, op.count);
280
281 // Pad the bounding box a little to make sure hairline points' bounds ar en't empty.
282 SkScalar stroke = SkMaxScalar(op.paint.getStrokeWidth(), 0.01f);
283 dst.outset(stroke/2, stroke/2);
284
285 return this->adjustAndMap(dst, &op.paint);
286 }
287
288 SkIRect bounds(const DrawPosText& op) const {
289 const int N = op.paint.countText(op.text, op.byteLength);
290 if (N == 0) {
291 return SkIRect::MakeEmpty();
292 }
293
294 SkRect dst;
295 dst.set(op.pos, op.paint.countText(op.text, N));
296 AdjustTextForFontMetrics(&dst, op.paint);
297 return this->adjustAndMap(dst, &op.paint);
298 }
299 SkIRect bounds(const DrawPosTextH& op) const {
300 const int N = op.paint.countText(op.text, op.byteLength);
301 if (N == 0) {
302 return SkIRect::MakeEmpty();
303 }
304
305 SkScalar left = op.xpos[0], right = op.xpos[0];
306 for (int i = 1; i < N; i++) {
307 left = SkMinScalar(left, op.xpos[i]);
308 right = SkMaxScalar(right, op.xpos[i]);
309 }
310 SkRect dst = { left, op.y, right, op.y };
311 AdjustTextForFontMetrics(&dst, op.paint);
312 return this->adjustAndMap(dst, &op.paint);
313 }
314
315 static void AdjustTextForFontMetrics(SkRect* rect, const SkPaint& paint) {
316 // FIXME: These bounds should be tight (and correct), but reading SkFont Metrics is likely
317 // a performance bottleneck. It's safe to overapproximate these metrics for speed. E.g.
318 // fTop <= 1.5 * paint.getTextSize(), fXMax <= 8 * fTop, etc.
319 SkPaint::FontMetrics metrics;
320 paint.getFontMetrics(&metrics);
321 rect->fLeft += metrics.fXMin;
322 rect->fTop += metrics.fTop;
323 rect->fRight += metrics.fXMax;
324 rect->fBottom += metrics.fBottom;
325 }
326
246 // Returns true if rect was meaningfully adjusted for the effects of paint, 327 // Returns true if rect was meaningfully adjusted for the effects of paint,
247 // false if the paint could affect the rect in unknown ways. 328 // false if the paint could affect the rect in unknown ways.
248 static bool AdjustForPaint(const SkPaint* paint, SkRect* rect) { 329 static bool AdjustForPaint(const SkPaint* paint, SkRect* rect) {
249 if (paint) { 330 if (paint) {
250 if (paint->canComputeFastBounds()) { 331 if (paint->canComputeFastBounds()) {
251 *rect = paint->computeFastBounds(*rect, rect); 332 *rect = paint->computeFastBounds(*rect, rect);
252 return true; 333 return true;
253 } 334 }
254 return false; 335 return false;
255 } 336 }
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 // Used to track the bounds of Save/Restore blocks and the control ops insid e them. 380 // Used to track the bounds of Save/Restore blocks and the control ops insid e them.
300 SkTDArray<SaveBounds> fSaveStack; 381 SkTDArray<SaveBounds> fSaveStack;
301 SkTDArray<unsigned> fControlIndices; 382 SkTDArray<unsigned> fControlIndices;
302 }; 383 };
303 384
304 } // namespace SkRecords 385 } // namespace SkRecords
305 386
306 void SkRecordFillBounds(const SkRecord& record, SkBBoxHierarchy* bbh) { 387 void SkRecordFillBounds(const SkRecord& record, SkBBoxHierarchy* bbh) {
307 SkRecords::FillBounds(record, bbh); 388 SkRecords::FillBounds(record, bbh);
308 } 389 }
OLDNEW
« no previous file with comments | « no previous file | tests/RecordDrawTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698